fix: support Koa2 / Node 6.2 #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leecade
changed the title
Current coverage is 98.11%@@ v2.x #20 diff @@
==========================================
Files 1 1
Lines 53 53
Methods 3 3
Messages 0 0
Branches 19 20 +1
==========================================
- Hits 53 52 -1
- Misses 0 1 +1
Partials 0 0
|
|
@leecade ci test fail |
fengmk2
changed the title
| @@ -51,7 +51,7 @@ module.exports = function(options) { | |||
| return function cors(ctx, next) { | |||
| // If the Origin header is not present terminate this set of steps. | |||
| // The request is outside the scope of this specification. | |||
| const requestOrigin = ctx.get('Origin'); | |||
| const requestOrigin = ctx.get('Origin') || ctx.origin; | |||
There was a problem hiding this comment.
can you add a test case for this fix?
There was a problem hiding this comment.
ctx.origin points to the url to which the client connects to not the origin header right? Is this fix correct?
|
can this be rebased and merged? |
|
What's the status of this? @fengmk2 |
|
@leecade should rebase and add a test case for this change. |
|
I think this PR can be closed since Node 6 support was just dropped since 3.0.0. |
|
close for now, seems it is not a fix for this problem. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18