-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt UV in GHA #629
Adopt UV in GHA #629
Conversation
@@ -1,8 +1,10 @@ | |||
name: Cron Test Dependencies | |||
|
|||
on: | |||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is highly unnecessary, but maybe come useful for testing --pre on a specific branch before merging.
We I don't have another way of running it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Left some minor suggestions because @MBrouns is certainly less active here these days. Feel free to merge once branch looks green.
Co-authored-by: vincent d warmerdam <vincentwarmerdam@gmail.com>
Co-authored-by: vincent d warmerdam <vincentwarmerdam@gmail.com>
Description
Not necessary but a nice to have for such minimal change.
Moves from
pip
touv
in Github ActionsDetails
Installing dependencies has a speedup between 2x and 4x, and overall running time between 1.1x and 2.4x