Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt UV in GHA #629

Merged
merged 16 commits into from
Mar 23, 2024
Merged

Adopt UV in GHA #629

merged 16 commits into from
Mar 23, 2024

Conversation

FBruzzesi
Copy link
Collaborator

@FBruzzesi FBruzzesi commented Mar 22, 2024

Description

Not necessary but a nice to have for such minimal change.
Moves from pip to uv in Github Actions

Details

Installing dependencies has a speedup between 2x and 4x, and overall running time between 1.1x and 2.4x

@@ -1,8 +1,10 @@
name: Cron Test Dependencies

on:
workflow_dispatch:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is highly unnecessary, but maybe come useful for testing --pre on a specific branch before merging.
We I don't have another way of running it

Copy link
Owner

@koaning koaning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left some minor suggestions because @MBrouns is certainly less active here these days. Feel free to merge once branch looks green.

FBruzzesi and others added 3 commits March 23, 2024 20:52
Co-authored-by: vincent d warmerdam  <vincentwarmerdam@gmail.com>
Co-authored-by: vincent d warmerdam  <vincentwarmerdam@gmail.com>
@FBruzzesi FBruzzesi merged commit df26619 into koaning:main Mar 23, 2024
17 checks passed
@FBruzzesi FBruzzesi deleted the feature/gha-uv branch March 23, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants