-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt UV in GHA #629
Merged
Merged
Adopt UV in GHA #629
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
2170d1a
uv in test gha
FBruzzesi 7ae06d7
typo
FBruzzesi 8e8574e
windows if case
FBruzzesi 0bd4078
windows if case
FBruzzesi d9eb857
and one more
FBruzzesi ff5bd27
and one more
FBruzzesi 35a20ea
install with pip
FBruzzesi d435c8c
more .github stuffs
FBruzzesi 96f237c
uv on system
FBruzzesi 2934508
uv if by system
FBruzzesi c768fcd
dependencies dispatch
FBruzzesi d603cc4
--system
FBruzzesi 9510929
PR Template
FBruzzesi c419219
Update .github/PULL_REQUEST_TEMPLATE.md
FBruzzesi 3780157
Update .github/PULL_REQUEST_TEMPLATE.md
FBruzzesi 97efef0
Merge branch 'main' into feature/gha-uv
FBruzzesi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,25 @@ | ||
Before working on a large PR, please check with @koaning or @MBrouns that they agree with the direction of the PR. This discussion should take place in a Github issue before working on the PR, unless it's a minor change like spelling in the docs. | ||
Before working on a large PR, please check with @FBruzzesi or @koaning to confirm that they agree with the direction of the PR. This discussion should take place in a [Github issue](https://github.com/koaning/scikit-lego/issues/new/choose) before working on the PR, unless it's a minor change like spelling in the docs. | ||
|
||
# Description | ||
|
||
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. | ||
|
||
Fixes # (issue) | ||
Fixes #(issue) | ||
|
||
## Type of change | ||
|
||
- [ ] Bug fix (non-breaking change which fixes an issue) | ||
- [ ] New feature (non-breaking change which adds functionality) | ||
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) | ||
|
||
|
||
# Checklist: | ||
## Checklist: | ||
|
||
- [ ] My code follows the style guidelines (flake8) | ||
- [ ] My code follows the style guidelines (ruff) | ||
- [ ] I have commented my code, particularly in hard-to-understand areas | ||
- [ ] I have made corresponding changes to the documentation (also to the readme.md) | ||
- [ ] I have added tests that prove my fix is effective or that my feature works | ||
- [ ] I have added tests to check whether the new feature adheres to the sklearn convention | ||
- [ ] New and existing unit tests pass locally with my changes | ||
|
||
If you feel your PR is ready for a review, ping @koaning or @mbrouns. | ||
If you feel your PR is ready for a review, ping @FBruzzesi or @koaning. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is highly unnecessary, but maybe come useful for testing --pre on a specific branch before merging.
WeI don't have another way of running it