Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace vuex with pinia/useState #4755

Closed
preschian opened this issue Jan 18, 2023 · 7 comments · Fixed by #6245
Closed

Replace vuex with pinia/useState #4755

preschian opened this issue Jan 18, 2023 · 7 comments · Fixed by #6245
Labels
$ ~<50usd A-nuxt chief enhancement New feature or request p1 preventing everyone from using app

Comments

@preschian
Copy link
Member

"Nuxt no longer provides a Vuex integration. Instead, the official Vue recommendation is to use pinia, which has built-in Nuxt support via a Nuxt module." https://nuxt.com/docs/migration/configuration#vuex

related code:

@preschian
Copy link
Member Author

@vikiival @roiLeo since we are moving forward with pinia, do we still need @kodadot1/vuex-options?

@roiLeo
Copy link
Contributor

roiLeo commented May 5, 2023

do we still need @kodadot1/vuex-options?

🤔 question is will it work with Nuxt3?
one option would be to rewritte it to pinia

@vikiival
Copy link
Member

vikiival commented May 5, 2023

@vikiival @roiLeo since we are moving forward with pinia, do we still need @kodadot1/vuex-options?

Good Q
happy to deprecate,
Move majority to statick

@vikiival vikiival added p1 preventing everyone from using app and removed p3 non-core, affecting less than 40% labels May 11, 2023
@yangwao yangwao added the chief label May 26, 2023
@yangwao
Copy link
Member

yangwao commented Jun 15, 2023

@roiLeo
Copy link
Contributor

roiLeo commented Jun 15, 2023

Last piece is on #6210, don't know what happened if we remove code

@vikiival
Copy link
Member

Last piece is on #6210, don't know what happened if we remove code

Like the important part there is to keep correct url params, correct usd calculation.

@roiLeo roiLeo mentioned this issue Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd A-nuxt chief enhancement New feature or request p1 preventing everyone from using app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants