Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

➖ remove store index #6087

Merged
merged 4 commits into from
May 26, 2023
Merged

➖ remove store index #6087

merged 4 commits into from
May 26, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented May 23, 2023

Goes after #5655

PR Type

  • Refactoring

Context

@netlify
Copy link

netlify bot commented May 23, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 00d85ca
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/647077b78b8658000800b90f
😎 Deploy Preview https://deploy-preview-6087--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added the small Pull request is small label May 23, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented May 23, 2023

AI-Generated Summary: This pull request removes the store/index.ts content and simplifies the pages/_prefix/transfer.vue file. In specific, 52 lines were removed in this patch, which mainly includes the removal of the isApiConnected getter and related functionality, and a simplification of the disabled computed property. This results in a cleaner implementation with less code.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 23, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@roiLeo roiLeo mentioned this pull request May 23, 2023
Closed
@roiLeo roiLeo marked this pull request as ready for review May 26, 2023 06:13
@roiLeo roiLeo requested a review from a team as a code owner May 26, 2023 06:13
@roiLeo roiLeo requested review from preschian and vikiival and removed request for a team May 26, 2023 06:13
@yangwao
Copy link
Member

yangwao commented May 26, 2023

@codeclimate
Copy link

codeclimate bot commented May 26, 2023

Code Climate has analyzed commit 00d85ca and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao yangwao merged commit cd91195 into kodadot:main May 26, 2023
@yangwao yangwao mentioned this pull request May 26, 2023
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@vikiival vikiival Awaiting requested review from vikiival vikiival is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roiLeo @yangwao @preschian