Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💥⚰️ Vuex Options (MILESTONE) #5979

Closed
5 tasks done
vikiival opened this issue May 15, 2023 · 6 comments · Fixed by #6645
Closed
5 tasks done

💥⚰️ Vuex Options (MILESTONE) #5979

vikiival opened this issue May 15, 2023 · 6 comments · Fixed by #6645
Labels
🍗 - schnitzel A-multi-chain interoperability issues across more parachains A-vue3 chief performance

Comments

@vikiival
Copy link
Member

vikiival commented May 15, 2023 •
edited
Loading

I see that we are getting various unwanted side effects by having / maintaining vuex-options

So I will be adding issues to get rid of dependency on this package.
The it's deeply rooted in the codebase (because we were relying on it the past).
I'll be also hacking with some non-trivial ones

Tasks:

Issues caused by this:
@vikiival vikiival added performance 🍗 - schnitzel chief A-vue3 A-multi-chain interoperability issues across more parachains labels May 15, 2023
This was referenced May 15, 2023
Closed
Closed
@roiLeo roiLeo mentioned this issue May 22, 2023
Closed
@yangwao
Copy link
Member

yangwao commented May 26, 2023

we got progress on this!

@roiLeo
Copy link
Contributor

roiLeo commented Jun 1, 2023 •
edited
Loading

TODO: (#6210)

in transfer.vue

  • remove dispatch('setApiUrl', ...)
  • replace $store.getters['availableNodesByPrefix']

@roiLeo roiLeo mentioned this issue Jun 16, 2023
Merged
@yangwao
Copy link
Member

yangwao commented Aug 4, 2023

Related

cc @Jarsen136

@vikiival
Copy link
Member Author

vikiival commented Aug 4, 2023

Does this mean we are out of vuex?

This was referenced Aug 10, 2023
Merged
Merged
@vikiival
Copy link
Member Author

Screenshot 2023-08-10 at 12 58 59

@yangwao
Copy link
Member

yangwao commented Aug 10, 2023

1 of 1 users approves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🍗 - schnitzel A-multi-chain interoperability issues across more parachains A-vue3 chief performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

➖ @kodadot1/vuex-options roiLeo/nft-gallery
3 participants
@yangwao @roiLeo @vikiival