Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on currentUrlPrefix #5984

Closed
3 tasks
Tracked by #5979
vikiival opened this issue May 15, 2023 · 4 comments
Closed
3 tasks
Tracked by #5979

Remove dependency on currentUrlPrefix #5984

vikiival opened this issue May 15, 2023 · 4 comments
Labels
$$ ~51-150usd 🧹 - clean-up A-refactoring Refactoring stuff, make code more readable, mitigating tech debt p1 preventing everyone from using app

Comments

@vikiival
Copy link
Member

The ultimate goal of KodaDot is to be a multichain explorer and if you want to do a specific action it should be located under the chain prefix.

However some parts of the app are dependent of the prefix from the vuex-options

Screenshot 2023-05-15 at 13 13 59

Make sure that :

  • usePrefix is using prefix only from the url
  • routes that needs any on-chain operation are under the prefix folder
  • properly test

This is a non-trivial task so proceed with care
@vikiival vikiival added $$ ~51-150usd A-refactoring Refactoring stuff, make code more readable, mitigating tech debt 🧹 - clean-up labels May 15, 2023
@vikiival vikiival mentioned this issue May 15, 2023
Closed
5 tasks
@roiLeo
Copy link
Contributor

roiLeo commented May 15, 2023

What do you think about rewritting it to pinia and move it under kodadot repo?

@vikiival
Copy link
Member Author

What do you think about rewritting it to pinia and move it under kodadot repo?

As mentioned in #5979 we will be suffering the side effects of having it

@roiLeo roiLeo mentioned this issue May 15, 2023
Merged
16 tasks
@roiLeo roiLeo mentioned this issue May 23, 2023
Merged
5 tasks
@yangwao yangwao added p2 core functionality, or is affecting 60% of app p1 preventing everyone from using app and removed p2 core functionality, or is affecting 60% of app labels May 23, 2023
@yangwao
Copy link
Member

yangwao commented May 26, 2023

@roiLeo roiLeo mentioned this issue May 31, 2023
Merged
@roiLeo
Copy link
Contributor

roiLeo commented Jun 16, 2023 •
edited
Loading

Capture d’écran 2023-06-16 à 10 17 18 AM

close in #6142 (sorry no test written)

@roiLeo roiLeo closed this as completed Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
$$ ~51-150usd 🧹 - clean-up A-refactoring Refactoring stuff, make code more readable, mitigating tech debt p1 preventing everyone from using app
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yangwao @roiLeo @vikiival