Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set address on prefix #6084

Merged
merged 3 commits into from
May 24, 2023
Merged

fix: set address on prefix #6084

merged 3 commits into from
May 24, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented May 23, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Had issue bounty label?

  • Fill up your KSM address: Payout

Copilot Summary

🤖 Generated by Copilot at 9fc456d

Prefix middleware to handle different address formats for different chains. It uses useIdentityStore and ss58Of to adapt the format based on the url.

🤖 Generated by Copilot at 9fc456d

Sing, O Muse, of the code that sets the address format
By the chain prefix in the url, a subtle mark of fate
That guides the useIdentityStore hook and the ss58Of function
To render the correct form, like Zeus who shapes the world by his unction

@kodabot
Copy link
Collaborator

kodabot commented May 23, 2023

WARNING @preschian PR for issue #6045 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #6045

@netlify
Copy link

netlify bot commented May 23, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 99b8905
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/646ca92f0ee56a00082cc026
😎 Deploy Preview https://deploy-preview-6084--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added the small Pull request is small label May 23, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented May 23, 2023

AI-Generated Summary: This pull request includes a fix for setting the address on prefix. It makes changes to the middleware/prefix.ts file by adding 5 new lines of code. The new code imports the useIdentityStore and ss58Of methods, and updates the function to set the correct address format using the identityStore.setCorrectAddressFormat() method with the ss58Of(urlPrefix.value) parameter.

@codeclimate
Copy link

codeclimate bot commented May 23, 2023

Code Climate has analyzed commit 99b8905 and detected 0 issues on this pull request.

View more on Code Climate.

@preschian preschian marked this pull request as ready for review May 23, 2023 12:07
@preschian preschian requested a review from a team as a code owner May 23, 2023 12:07
@preschian preschian requested review from roiLeo and daiagi and removed request for a team May 23, 2023 12:07
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep store? ref #5984

I've remove something like this in #5655 (formatPlugin)

otherwise ✅ code lgtm (I'd still be careful about #6064)

@prury
Copy link
Member

prury commented May 23, 2023

Was able to successfully reproduce the issue using Chrome, tested with deployed version and its working properly.

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label May 23, 2023
@yangwao
Copy link
Member

yangwao commented May 24, 2023

pay 30 usd

@yangwao yangwao merged commit 4e101d8 into main May 24, 2023
@yangwao yangwao deleted the fix/set-address-on-prefix branch May 24, 2023 10:20
@yangwao
Copy link
Member

yangwao commented May 24, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 25.05 USD/KSM ~ 1.198 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0xb1af0b6136a864e90f75133385ff880c1656584b6faf12f7f6e227a2cc5b56ad

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label May 24, 2023
@preschian
Copy link
Member Author

Should we keep store? ref #5984

I've remove something like this in #5655 (formatPlugin)

otherwise ✅ code lgtm (I'd still be careful about #6064)

oohh, didn't aware of these PR. checking

This was referenced May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update wallet address/identity based on prefix
6 participants