Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar consistency #6262

Closed
exezbcz opened this issue Jun 17, 2023 · 4 comments · Fixed by #6287
Closed

Sidebar consistency #6262

exezbcz opened this issue Jun 17, 2023 · 4 comments · Fixed by #6287
Labels
A-notification A-sidebar related to sidebars p3 non-core, affecting less than 40% visual change not affecting ux of app

Comments

@exezbcz
Copy link
Member

exezbcz commented Jun 17, 2023

image
image
image

  • please make the top part of the notification sidebar the same as the other sidebars - that means 32px horizontal padding and 16px vertical.
  • change the text of connect wallet sidebar to "connect wallet."

image
@exezbcz exezbcz added p3 non-core, affecting less than 40% visual change not affecting ux of app A-notification A-sidebar related to sidebars labels Jun 17, 2023
@prachi00 prachi00 self-assigned this Jun 17, 2023
@kodabot
Copy link
Collaborator

kodabot commented Jun 17, 2023

ASSIGNED - @prachi00 🔒 LOCKED -> Monday, June 19th 2023, 10:04:41 UTC -> 36 hours

@prachi00
Copy link
Member

Screen Shot 2023-06-18 at 4 58 10 PM @exezbcz it is 32px and 16px, notification sidebar, like the others

@kodabot
Copy link
Collaborator

kodabot commented Jun 19, 2023

ASSIGNMENT EXPIRED - @prachi00 has been unassigned.

@exezbcz
Copy link
Member Author

exezbcz commented Jun 19, 2023

the notification sidebar heading container is still thicker than the others
image

  • try opening notification and then the profile. You will see that they are of different heights.

prachi00 added a commit that referenced this issue Jun 20, 2023
@prachi00
#6262 sidebar consistency
059d2e9
@prachi00 prachi00 mentioned this issue Jun 20, 2023
Merged
7 tasks
vikiival pushed a commit that referenced this issue Jun 21, 2023
@prachi00
#6262 sidebar consistency (#6287)
ecbe9df 
* #6262 sidebar consistency

* check for profile heading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-notification A-sidebar related to sidebars p3 non-core, affecting less than 40% visual change not affecting ux of app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#6262 sidebar consistency kodadot/nft-gallery
3 participants
@prachi00 @exezbcz @kodabot