Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6262 sidebar consistency #6287

Merged
merged 4 commits into from
Jun 21, 2023
Merged

#6262 sidebar consistency #6287

merged 4 commits into from
Jun 21, 2023

Conversation

prachi00
Copy link
Member

aThank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
Screen Shot 2023-06-19 at 9 16 53 PM

Copilot Summary

@prachi00 prachi00 requested a review from a team as a code owner June 20, 2023 04:17
@prachi00 prachi00 requested review from preschian and daiagi and removed request for a team June 20, 2023 04:17
@kodabot
Copy link
Collaborator

kodabot commented Jun 20, 2023

WARNING @prachi00 PR for issue #6262 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #6262

@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 1781770
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6492301a8a68d00008dca8b0
😎 Deploy Preview https://deploy-preview-6287--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 20, 2023

AI-Generated Summary: This pull request addresses issue #6262 by improving sidebar consistency across multiple components. It updates the ConnectWalletModal and NotificationBoxModal titles to use the same CSS classes, and moves the .modal-card-title styling from the _connect-wallet.scss file to apply globally. The changes made involve 3 files with 8 insertions and 8 deletions.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jun 20, 2023
@preschian preschian requested a review from exezbcz June 20, 2023 06:31
@prury
Copy link
Member

prury commented Jun 20, 2023

They are all about the same height now, good.

@prachi00, when you changed the Connect Wallet sidebar to Connect Wallet, you also changed the profile to Connect wallet:
image

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jun 20, 2023
@exezbcz
Copy link
Member

exezbcz commented Jun 20, 2023

yup, works for me once the connect wallet profile is changed

thank you!

@prachi00
Copy link
Member Author

They are all about the same height now, good.

@prachi00, when you changed the Connect Wallet sidebar to Connect Wallet, you also changed the profile to Connect wallet: image

arent they the same sidebar modal?

@exezbcz
Copy link
Member

exezbcz commented Jun 20, 2023

@prachi00 yes, but connect wallet is not what the profile sidebar is about

@prury
Copy link
Member

prury commented Jun 20, 2023

They are all about the same height now, good.
@prachi00, when you changed the Connect Wallet sidebar to Connect Wallet, you also changed the profile to Connect wallet: image

arent they the same sidebar modal?

they are, but their states are different depending if the user has his/her wallet connected or not, for example:

  • the title here should be "connect wallet":
    image

and once the user connects its wallet, it should be renamed to Profile:
image

@prachi00
Copy link
Member Author

@prury got it, fixed

@codeclimate
Copy link

codeclimate bot commented Jun 20, 2023

Code Climate has analyzed commit 1781770 and detected 0 issues on this pull request.

View more on Code Climate.

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Jun 21, 2023
@vikiival vikiival merged commit ecbe9df into main Jun 21, 2023
@vikiival vikiival deleted the feat-sidebar-consistent branch June 21, 2023 11:28
This was referenced Jun 21, 2023
This was referenced Jun 21, 2023
This was referenced Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar consistency
6 participants