Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modal style #5831

Merged
merged 9 commits into from
May 8, 2023
Merged

fix: modal style #5831

merged 9 commits into from
May 8, 2023

Conversation

Gavin-Gong
Copy link
Contributor

@Gavin-Gong Gavin-Gong commented Apr 29, 2023 •
edited by ghost
Loading

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 41870e2

Improved the appearance and functionality of the sharing modal. Fixed a CSS selector bug that affected the QR code button. Removed a redundant z-index property from the body element.

🤖 Generated by Copilot at 41870e2

We're working on the code, me hearties, yo ho ho
We're fixing up the modal and the QR code, yo ho ho
We're changing all the selectors and the z-index too
We're making it look pretty and we're almost through, yo ho ho

@Gavin-Gong Gavin-Gong requested a review from a team as a code owner April 29, 2023 10:52
@Gavin-Gong Gavin-Gong requested review from preschian and roiLeo and removed request for a team April 29, 2023 10:52
@kodabot
Copy link
Collaborator

kodabot commented Apr 29, 2023

SUCCESS @Gavin-Gong PR for issue #5829 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Apr 29, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit cf47d5a
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6458e70a9de4a40008cdd8c1
😎 Deploy Preview https://deploy-preview-5831--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 29, 2023

AI-Generated Summary: This pull request addresses styling issues with the modal component. It includes changes to three files: Sharing.vue, ModalWrapper.vue, and global.scss. The patch modifies the CSS selector in Sharing.vue, adds new styles to ModalWrapper.vue, and removes an unnecessary z-index property from global.scss.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Apr 29, 2023
@exezbcz
Copy link
Member

exezbcz commented Apr 29, 2023

good! works now, could you please also add fill to the container so its not transparent

thanks!

@Gavin-Gong
Copy link
Contributor Author

good! works now, could you please also add fill to the container so its not transparent

done, I used theme background color to fill the content container

roiLeo
roiLeo suggested changes May 2, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to rewrite ModalWrapper with new NeoModal component

Preview doesn't work for me
Screenshot 2023-05-02 at 08-56-52 Aksum KodaDot - NFT Market Explorer

styles/global.scss Show resolved Hide resolved
components/shared/modals/ModalWrapper.vue Outdated Show resolved Hide resolved
@roiLeo roiLeo added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label May 2, 2023
preschian
preschian requested changes May 2, 2023
View reviewed changes
Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already pointed by @roiLeo

@preschian
Copy link
Member

On the collection page, some components are missing when the modal is shown. is it related?

Screenshot 2023-05-03 084841

@Gavin-Gong
Copy link
Contributor Author

On the collection page, some components are missing when the modal is shown. is it related?

Screenshot 2023-05-03 084841

Not related，The NeoModal component incorrectly caused the Navbar component to calculate the top value .
image

As a workaround, setting o-modal scroll="clip" can solve this problem.

roiLeo
roiLeo approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀

wfm ✅

you might want to check #5852 as we still have some <b-modal /> code to replace

@roiLeo roiLeo added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels May 5, 2023
preschian
preschian reviewed May 5, 2023
View reviewed changes
Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the DeepSource maybe?

@Gavin-Gong
Copy link
Contributor Author

fix the DeepSource maybe?

@Jarsen136 Done

vikiival
vikiival reviewed May 6, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️

@vikiival vikiival enabled auto-merge May 8, 2023 12:11
@codeclimate
Copy link

codeclimate bot commented May 8, 2023

Code Climate has analyzed commit cf47d5a and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented May 8, 2023

pay 30 usd

@yangwao yangwao disabled auto-merge May 8, 2023 20:02
@yangwao
Copy link
Member

yangwao commented May 8, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 25.62 USD/KSM ~ 1.171 $KSM
🧗 GqheyaQ3c8SFBJYorTXyLW6jvLXKNAXzbad77NXoLYJBXXs
🔗 0xa722078da29167811b2cfe056d4cbf6b4da8acc7e58932c5640d289316456f7d

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label May 8, 2023
@yangwao yangwao merged commit 22a4fb7 into kodadot:main May 8, 2023
@Gavin-Gong Gavin-Gong deleted the fix/5829 branch May 9, 2023 00:34
@yangwao yangwao mentioned this pull request May 10, 2023
Merged
@roiLeo
Copy link
Contributor

roiLeo commented May 17, 2023

Maybe related but I've got errors/warning on user page

Capture d’écran 2023-05-17 à 9 54 14 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian requested changes

@daiagi daiagi daiagi left review comments

@roiLeo roiLeo roiLeo approved these changes

@vikiival vikiival vikiival approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QR code modal is not fully displayed on profile page
8 participants
@Gavin-Gong @kodabot @exezbcz @preschian @yangwao @roiLeo @vikiival @daiagi