Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goodbye Buefy #5852

Closed
37 tasks done
roiLeo opened this issue May 3, 2023 · 28 comments · Fixed by #6744
Closed
37 tasks done

Goodbye Buefy #5852

roiLeo opened this issue May 3, 2023 · 28 comments · Fixed by #6744
Labels
$$ ~51-150usd 🧹 - clean-up A-vue3 chief enhancement New feature or request p1 preventing everyone from using app S-blocked-✋ UX first Improvement for UX

Comments

@roiLeo
Copy link
Contributor

roiLeo commented May 3, 2023

Rewrite Buefy components in libs/ui using Oruga-ui

part of

In Progress

Done

lmk if you want to work on a specific component.

@roiLeo roiLeo added enhancement New feature or request UX first Improvement for UX p2 core functionality, or is affecting 60% of app 🧹 - clean-up A-vue3 labels May 3, 2023
@yangwao yangwao added the chief label May 3, 2023
@prachi00
Copy link
Member

prachi00 commented May 4, 2023

@roiLeo
I'll do

infinith4 added a commit to infinith4/kodadot_nft-gallery that referenced this issue May 4, 2023
@prachi00
Copy link
Member

prachi00 commented May 4, 2023

I'll do this now:

@prachi00
Copy link
Member

prachi00 commented May 5, 2023

@roiLeo we also use <b-autocomplete which isnt mentioned in description

@roiLeo roiLeo mentioned this issue May 5, 2023
16 tasks
0xemagic added a commit to 0xemagic/nft-gallery that referenced this issue May 5, 2023
@0xemagic
Copy link

0xemagic commented May 5, 2023

@roiLeo
I will handle the checkbox part.

@prachi00
Copy link
Member

prachi00 commented May 5, 2023

I'll also do <b-field to neofield as I need that in <neoinput

@prachi00
Copy link
Member

prachi00 commented May 8, 2023

Also doing this now:

@prachi00
Copy link
Member

prachi00 commented May 9, 2023

changing <b-button to <neobutton would change the ui of buttons everywhere, are we okay with that? @roiLeo

@roiLeo
Copy link
Contributor Author

roiLeo commented May 9, 2023

changing <b-button to <neobutton would change the ui of buttons everywhere, are we okay with that?

Nope, we sould keep UI how it is maybe try to create new variant?

@preschian
Copy link
Member

will check on <b-carousel /> and <b-dropdown-item />

@preschian preschian mentioned this issue May 9, 2023
18 tasks
@preschian
Copy link
Member

will check on <b-steps /> and <b-steps-item />

@preschian preschian mentioned this issue May 11, 2023
17 tasks
prachi00 added a commit that referenced this issue May 12, 2023
@reviewpad reviewpad bot mentioned this issue May 12, 2023
16 tasks
vikiival added a commit that referenced this issue May 12, 2023
@preschian
Copy link
Member

preschian commented May 13, 2023

will check on b-switch, b-datepicker, and b-radio-button

edit: currently there is no equivalent of b-radio-button on oruga

@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 9, 2023

Hey @brano-hozza just saw your oruga issue, I think this is stil doable with a workaround by adding icon prop to o-select component. And then you should be able to update class color.

Screenshot 2023-06-09 at 10-53-05 KodaDot - NFT Market Explorer

@brano-hozza brano-hozza mentioned this issue Jun 10, 2023
15 tasks
@preschian
Copy link
Member

will check on b-tabs and b-tab-item

@preschian
Copy link
Member

will check b-collapse also

yangwao added a commit that referenced this issue Jun 14, 2023
This was referenced Jun 15, 2023
@preschian preschian mentioned this issue Jun 20, 2023
6 tasks
@brano-hozza brano-hozza mentioned this issue Jun 26, 2023
16 tasks
@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 27, 2023

For Programmatic stuff (modal, toast, notification..), I think we need to do some important changes in libs/ui:

  • use vue3 (or nuxt check out histoire examples)
  • replace @histoire/plugin-vue2
  • import @oruga-ui/oruga-next
  • test components
  • profit!

ref #5611

edit: #6610 (comment)

@yangwao yangwao added p1 preventing everyone from using app and removed p2 core functionality, or is affecting 60% of app labels Aug 6, 2023
@yangwao
Copy link
Member

yangwao commented Aug 9, 2023

Realistically we have it done all? Or are there some which might pop up?

@yangwao yangwao added the $$ ~51-150usd label Aug 9, 2023
@roiLeo
Copy link
Contributor Author

roiLeo commented Aug 9, 2023

Realistically we have it done all? Or are there some which might pop up?

Notification, Modal, Snackbar & Toast

see #6610 (comment) we'll need to make a big bang (Vue3 => Nuxt3 => Oruga-next) to close this one

@preschian
Copy link
Member

Notification, Modal, Snackbar & Toast

see #6610 (comment) we'll need to make a big bang (Vue3 => Nuxt3 => Oruga-next) to close this one

I think we can make a separate issue for this

  1. migrate Modal -> refactor: programmatic modal #6714
  2. migrate Notification & Toast

and then, when we migrate to Nuxt3, we need to migrate to oruga-next also

  1. migrate oruga-next -> 🔧 libs ui vue3 #6610

we need to remove buefy first before we go to no.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$$ ~51-150usd 🧹 - clean-up A-vue3 chief enhancement New feature or request p1 preventing everyone from using app S-blocked-✋ UX first Improvement for UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants