Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 NeoInputitems #6183

Merged
merged 7 commits into from
Jun 15, 2023
Merged

🔧 NeoInputitems #6183

merged 7 commits into from
Jun 15, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jun 7, 2023 •
edited
Loading

This can be tested on /rmrk/mint where you can add/remove tags

part of #5852

  • rewritte vue composition api for AttributeTagInput
  • create NeoInputitems in libs/ui
  • deleted unused components

Screenshot 2023-06-15 at 10-33-50 KodaDot Low fees and low carbon minting KodaDot - NFT Market Explorer

Screenshot 2023-06-15 at 11-21-30 KodaDot Low fees and low carbon minting KodaDot - NFT Market Explorer

@netlify
Copy link

netlify bot commented Jun 7, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 577a33a
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/648ad8370106d700075f50ef
😎 Deploy Preview https://deploy-preview-6183--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 7, 2023

AI-Generated Summary: This pull request includes updates and deletions across 7 files. It adds a new NeoInputitems component and removes the Facts.vue and ArweaveLink.vue components, along with other changes to AttributeTagInput.vue that include switching to the new NeoInputitems component. These changes aim to improve the overall code quality and maintainability.

@reviewpad reviewpad bot added the medium Pull request is medium label Jun 7, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 7, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@roiLeo roiLeo mentioned this pull request Jun 7, 2023
Closed
37 tasks
@roiLeo roiLeo changed the title 🔧 wip: NeoTaginput 🔧 wip: NeoInputitems Jun 7, 2023
@prury
Copy link
Member

prury commented Jun 7, 2023

white background field in Dark mode:
image

bottom padding needed:
image

may or may not be intentional:

07.06.2023_11.18.57_REC.mp4

@roiLeo roiLeo changed the title 🔧 wip: NeoInputitems 🔧 NeoInputitems Jun 15, 2023
@roiLeo roiLeo marked this pull request as ready for review June 15, 2023 08:35
@roiLeo roiLeo requested a review from a team as a code owner June 15, 2023 08:35
@roiLeo roiLeo requested review from vikiival and Jarsen136 and removed request for a team June 15, 2023 08:35
@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 15, 2023 •
edited
Loading

Component updated with autocomplete padding & hover

edit: darkmode in progress

Screenshot 2023-06-15 at 11-21-30 KodaDot Low fees and low carbon minting KodaDot - NFT Market Explorer

@roiLeo roiLeo requested a review from prury June 15, 2023 08:36
@roiLeo roiLeo marked this pull request as draft June 15, 2023 08:45
@roiLeo roiLeo marked this pull request as ready for review June 15, 2023 09:22
@codeclimate
Copy link

codeclimate bot commented Jun 15, 2023

Code Climate has analyzed commit 577a33a and detected 0 issues on this pull request.

View more on Code Climate.

vikiival
vikiival reviewed Jun 15, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming otherwise LGTM

@prury
Copy link
Member

prury commented Jun 15, 2023 •
edited
Loading

seems to be working fine, is there any place i can check those tags after i mint it?

@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 15, 2023

seems to be working fine, is there any place i can check those tags after i mint it?

What if I told you it's purely
magical-magic

@vikiival vikiival merged commit 38c90e8 into kodadot:main Jun 15, 2023
This was referenced Jun 15, 2023
Merged
Merged
@roiLeo roiLeo deleted the chore/Buefy/b-taginput branch June 19, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@prury prury Awaiting requested review from prury

Assignees
No one assigned
Labels
medium Pull request is medium waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roiLeo @prury @vikiival @Jarsen136