Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add NeoSwitch #5945

Merged
merged 4 commits into from
May 17, 2023
Merged

refactor: add NeoSwitch #5945

merged 4 commits into from
May 17, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented May 13, 2023 •
edited
Loading

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

image

Copilot Summary

🤖 Generated by Copilot at 0d47170

The pull request replaces the b-switch component from Buefy with the NeoSwitch component from the UI library in various components of the NFT gallery. The NeoSwitch component is a custom switch element that improves the UI consistency and style of the application. The pull request also adds the NeoSwitch component to the UI library and showcases it in a story file.

🤖 Generated by Copilot at 0d47170

We're switching out the switches, me hearties, yo ho ho
We're using NeoSwitch from the UI library, don't you know
It makes our interface look so fine and shiny, yes indeed
So heave away and pull the rope on the count of three

@netlify
Copy link

netlify bot commented May 13, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 92cff35
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64647a50745e510008c78fdb
😎 Deploy Preview https://deploy-preview-5945--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 13, 2023

AI-Generated Summary: This pull request includes a refactor that adds a new NeoSwitch component to the project, replacing the b-switch component in various locations. The changes affect components such as ArweaveUploadSwitch.vue, SimpleMint.vue, SeriesTable.vue, Interface.vue, Support.vue, BasicSwitch.vue, and SpotlightTable.vue. Additionally, the pull request introduces NeoSwitch.story.vue and NeoSwitch.vue files into the libs/ui/src/components/NeoSwitch directory. Overall, the changes involve 82 insertions and 66 deletions.

@reviewpad reviewpad bot added the medium Pull request is medium label May 13, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented May 13, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@preschian preschian marked this pull request as ready for review May 13, 2023 08:12
@preschian preschian requested a review from a team as a code owner May 13, 2023 08:12
@preschian preschian requested review from roiLeo and daiagi and removed request for a team May 13, 2023 08:12
@preschian preschian marked this pull request as draft May 13, 2023 08:27
@preschian preschian marked this pull request as ready for review May 13, 2023 11:55
roiLeo
roiLeo approved these changes May 13, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ code lgtm
✅ wfm

libs/ui/src/components/NeoSwitch/NeoSwitch.story.vue Show resolved Hide resolved
@roiLeo roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved and removed waiting-for-review labels May 13, 2023
@roiLeo roiLeo mentioned this pull request May 13, 2023
Closed
37 tasks
@roiLeo roiLeo added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review and removed waiting-for-review labels May 16, 2023
@yangwao
Copy link
Member

yangwao commented May 16, 2023

Please, resolve conflicts in code, happy to merge it!

@yangwao
Copy link
Member

yangwao commented May 16, 2023

time for saved replies 👀

Screen.Recording.2023-05-16.at.12.12.58.mov

@codeclimate
Copy link

codeclimate bot commented May 17, 2023

Code Climate has analyzed commit 92cff35 and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo merged commit 9b483ba into main May 17, 2023
@roiLeo roiLeo deleted the refactor/neo-switch branch May 17, 2023 06:58
@yangwao yangwao mentioned this pull request May 18, 2023
Merged
@yangwao yangwao mentioned this pull request May 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@daiagi daiagi daiagi approved these changes

Assignees
No one assigned
Labels
medium Pull request is medium S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@preschian @yangwao @roiLeo @daiagi