#5852 Neo Input and Neo Field

[prachi00]

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

• Bugfix
• Feature
• Refactoring

Context

• Closes #
• Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

• My contribution builds clean without any errors or warnings
• I've merged recent default branch -- main and I've no conflicts
• I've tried to respect high code quality standards
• I've didn't break any original functionality

Optional

• I've tested it at </ksm/collection>
• I've tested PR on mobile
• I've written unit tests 🧪
• I've found edge cases

Had issue bounty label?

• Fill up your KSM address:
  [Payout]https://kodadot.xyz/dot/transfer?target=13Qx65nLd6SwdtjrRyuoEtp9CKXhF651xdHBPaXcvhwKm4N1

Community participation

• Are you at KodaDot Discord?

Screenshot 📸

• My fix has changed something on UI; a screenshot is best to understand changes for others.
  SS
  
  

Copilot Summary

🤖 Generated by Copilot at e1b9ba3

No summary available (Limit exceeded: required to process 75846 tokens, but only 50000 are allowed per call)

🤖 Generated by Copilot at 7b7ed90

We are the NeoFields, we rise from the ashes
We replace the b-fields, we bring the new flashes
We are the NeoFields, we rule the forms and grids
We crush the b-fields, we are the Neo kids

[netlify]

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	331c471
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/64765187e08abe00080a625e
😎 Deploy Preview	https://deploy-preview-5870--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[reviewpad]

Reviewpad Report

⚠️ Warnings

• Please link an issue to the pull request

[vikiival]

@prachi00 can you provide screenshot pls?

[prachi00]

SS

@prachi00 can you provide screenshot pls?

added some

[vikiival]

@prachi00 can you please resolve conflicts?

[prachi00]

@prachi00 can you please resolve conflicts?

done

[vikiival]

~

[roiLeo]

please could you check

• type="is-... => variant="..."
• remove message prop on NeoField

[vikiival]

Agree with @roiLeo

[vikiival]

@kodadot/qa-guild is it possible to check this ? Seems quite a big change 😶

[prachi00]

it seems theres an icon that isnt showing when form is invalid and its taking up all the space

there is no icon named alert-circle on fa https://fontawesome.com/icons/alert-circle?s=solid. could you change to something else?

I didnt add it though, this icon was added by oruga, I'll look into replacing it if we can

[prachi00]

fixed the conflicts again, can we merge now, I'll do the rest of styling changes in followup issue
@vikiival

[vikiival]

@prachi00 can you please open the follow-up issue with changes that needs to be done?

[prachi00]

@prachi00 can you please open the follow-up issue with changes that needs to be done?

done

[preschian]

@prachi00 to mock matchmedia in the failed test

Object.defineProperty(window, 'matchMedia', {
  writable: true,
  value: vi.fn().mockImplementation((query) => ({
    matches: false,
    media: query,
    onchange: null,
    addListener: vi.fn(),
    removeListener: vi.fn(),
    addEventListener: vi.fn(),
    removeEventListener: vi.fn(),
    dispatchEvent: vi.fn(),
  })),
})

I didnt add it though, this icon was added by oruga, I'll look into replacing it if we can

yes, that one default value from oruga. need to change that in the seperate PR https://github.com/oruga-ui/oruga/blob/develop/packages/oruga/src/utils/FormElementMixin.js#L113

otherwise lgtm

[vikiival]

So 🥺

[roiLeo]

So 🥺

[prachi00]

resolved conflicts again, can be merged now

[codeclimate]

Code Climate has analyzed commit 331c471 and detected 0 issues on this pull request.

View more on Code Climate.

[prachi00]

Also, e2e test cases are failing on main now, I have fixed some of them in this pr by removing it as I think it doesnt exist anymore, I hope that is correct, more are failing but I want to confirm that removing them is the right way to fix it?
let me know if I need to revert those changes if we need them, i'll do it 🫣
CC @preschian @vikiival @roiLeo

[prachi00]

Also, e2e test cases are failing on main now, I have fixed some of them in this pr by removing it as I think it doesnt exist anymore, I hope that is correct, more are failing but I want to confirm that removing them is the right way to fix it? let me know if I need to revert those changes if we need them, i'll do it 🫣 CC @preschian @vikiival @roiLeo

PS can we merge this pr now please, as the test cases failing are not related to this anyway

[vikiival]

I hope that is correct,

So that means you don't propagate them?

[prachi00]

I hope that is correct,

So that means you don't propagate them?

what do you mean propagate?

[vikiival]

what do you mean propagate?

What was the reason to remove lines from the tests.
And how to bring the back

[prachi00]

what do you mean propagate?

What was the reason to remove lines from the tests. And how to bring the back

because they did not exist and thats why they failed, do we even want them back?