Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add NeoRadio and NeoRadioButton #5976

Merged
merged 5 commits into from
May 17, 2023
Merged

refactor: add NeoRadio and NeoRadioButton #5976

merged 5 commits into from
May 17, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented May 15, 2023 •
edited
Loading

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Screenshot 2023-05-15 165553

Copilot Summary

🤖 Generated by Copilot at 3e98ea9

Replaced b-radio-button components with custom NeoRadioButton components in the gallery and radio select components, and removed unused radio buttons from the series table component. Added the code and documentation for the NeoRadioButton component to the @kodadot1/brick library.

🤖 Generated by Copilot at 3e98ea9

We are the NeoRadio, we are the new sound
We break the chains of b-field, we burn the old code down
We rise from the @oruga-ui/oruga, we mix in our own style
We are the NeoRadioButton, we rock the gallery wild

@netlify
Copy link

netlify bot commented May 15, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit e7f26fa
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64647bb775d33a0008acb8ec
😎 Deploy Preview https://deploy-preview-5976--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 15, 2023

AI-Generated Summary: This pull request introduces a refactor that adds new components, NeoRadio and NeoRadioButton, along with their corresponding story file. It updates the Gallery/Layout.vue, SeriesTable.vue, and RadioSelect.vue components to use the new NeoRadioButton component. Additionally, the new components are exported in index.ts. In total, 230 lines were added and 40 lines were deleted across 7 files.

@reviewpad reviewpad bot added the medium Pull request is medium label May 15, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented May 15, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@preschian
Copy link
Member Author

seems like there is some issue with npm registry. retrying the pipeline

image

roiLeo
roiLeo approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ code lgtm

@preschian preschian marked this pull request as ready for review May 16, 2023 07:44
@preschian preschian requested a review from a team as a code owner May 16, 2023 07:44
@preschian preschian requested review from vikiival and Jarsen136 and removed request for a team May 16, 2023 07:44
@preschian preschian mentioned this pull request May 16, 2023
Closed
37 tasks
@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label May 16, 2023
vikiival
vikiival approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@codeclimate
Copy link

codeclimate bot commented May 16, 2023

Code Climate has analyzed commit 4398fd5 and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo merged commit c31453b into main May 17, 2023
@roiLeo roiLeo deleted the refactor/neo-radio-button branch May 17, 2023 07:01
This was referenced May 18, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@vikiival vikiival vikiival approved these changes

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136 Jarsen136 is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
medium Pull request is medium S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@preschian @roiLeo @vikiival