Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NeoCarousel #5884

Merged
merged 2 commits into from
May 11, 2023
Merged

feat: NeoCarousel #5884

merged 2 commits into from
May 11, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented May 9, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

Copilot Summary

🤖 Generated by Copilot at 9b88379

This pull request introduces a new carousel component and its item component, based on the @oruga-ui/oruga library, and removes the unused CuratedList.vue component. The new components are exported from the libs/ui/src/index.ts file and can be used to display collections of NFTs.

🤖 Generated by Copilot at 9b88379

New carousel spins
Extending @oruga-ui
Autumn leaves in view

@netlify
Copy link

netlify bot commented May 9, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 2d8ae32
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/645b96e56211c5000867da9b
😎 Deploy Preview https://deploy-preview-5884--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 9, 2023

AI-Generated Summary: This pull request introduces the NeoCarousel component and removes the CuratedList.vue component. It adds an index.d.ts file for type declarations, and makes adjustments to the imports in the index.ts file. The new components, NeoCarousel and NeoCarouselItem, are extended from Oruga's OCarousel and OCarouselItem components, respectively.

@reviewpad reviewpad bot added the medium Pull request is medium label May 9, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented May 9, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@roiLeo roiLeo mentioned this pull request May 9, 2023
37 tasks
@preschian preschian marked this pull request as ready for review May 9, 2023 10:25
@preschian preschian requested a review from a team as a code owner May 9, 2023 10:25
@preschian preschian requested review from daiagi and Jarsen136 and removed request for a team May 9, 2023 10:25
@preschian preschian requested a review from roiLeo May 9, 2023 10:26
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, didn't knew we don't use CuratedList component anymore.

For now it's ok, but latter I would like to see NeoCarousel.story

✅ code lgtm

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label May 9, 2023
@daiagi
Copy link
Contributor

daiagi commented May 9, 2023

didn't know about extends

nice one 👍

@codeclimate
Copy link

codeclimate bot commented May 10, 2023

Code Climate has analyzed commit 2d8ae32 and detected 0 issues on this pull request.

View more on Code Climate.

@preschian
Copy link
Member Author

For now it's ok, but latter I would like to see NeoCarousel.story

noted, will add this alongside with NeoSteps component

@roiLeo roiLeo added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed waiting-for-review labels May 10, 2023
@vikiival vikiival merged commit 502276b into main May 11, 2023
@vikiival vikiival deleted the feat/neo-carousel branch May 11, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants