Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5852 Buefy checkbox to neo checkbox #5868

Closed
wants to merge 1 commit into from

Conversation

0xemagic
Copy link

@0xemagic 0xemagic commented May 5, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 8a05013

Updated checkbox components to use NeoCheckbox from @kodadot1/brick for better UI design and consistency. Affected files are Holder.vue and BasicCheckbox.vue.

🤖 Generated by Copilot at 8a05013

To make the UI more refined
We replaced Buefy checkboxes in kind
With NeoCheckbox from brick
Which is custom and slick
And now our components are well-aligned

@0xemagic 0xemagic requested a review from a team as a code owner May 5, 2023 13:45
@0xemagic 0xemagic requested review from preschian and Jarsen136 and removed request for a team May 5, 2023 13:45
@kodabot
Copy link
Collaborator

kodabot commented May 5, 2023

WARNING @emagici PR for issue #5852 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #5852

@netlify
Copy link

netlify bot commented May 5, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 8a05013
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64550892d8edc500072c0446
😎 Deploy Preview https://deploy-preview-5868--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 5, 2023

AI-Generated Summary: This pull request replaces Buefy's checkbox component with the new NeoCheckbox component in two files: Holder.vue and BasicCheckbox.vue. The changes include updating the import statements and modifying the template, resulting in 7 insertions and 5 deletions.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 5, 2023
@codeclimate
Copy link

codeclimate bot commented May 5, 2023

Analysis results are not available for those commits

View more on Code Climate.

@roiLeo roiLeo mentioned this pull request May 5, 2023
37 tasks
@reviewpad
Copy link
Contributor

reviewpad bot commented May 5, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jarsen136 Jarsen136 added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label May 5, 2023
@vikiival
Copy link
Member

cc @emagici

@0xemagic
Copy link
Author

@vikiival working in progress

@vikiival
Copy link
Member

Hello, its been more than a week since this PR has been raised.

I am happy to see the working version of this feature 😇.

For now I am closing this one.

@vikiival vikiival closed this May 14, 2023
@roiLeo roiLeo mentioned this pull request May 15, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-changes-requested-🤞 PR is almost good to go, just some fine tunning small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants