-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
➖ remove b-tooltip component #5856
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
AI-Generated Summary: This pull request removes the |
Reviewpad Report
|
Sir Oruga tooltip exist https://oruga.io/components/Tooltip.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have tooltip in oruga
Sure thing, won't fix "Settings" Tooltip as it's bad UX. |
I would rather opt in for oruga tooltip, and do UX stuff with redesign |
cc @exezbcz |
@vikiival what is needed 👀 |
nvm forgot to replace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise oki
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please try to remove append-to-body
wherever possible to avoid tooltip shown not above content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all the tooltips under GalleryItemActionType need append-to-body
otherwise they are hidden
@@ -7,48 +7,48 @@ | |||
</div> | |||
</template> | |||
<b-dropdown-item has-link> | |||
<b-tooltip | |||
position="is-left" | |||
<NeoTooltip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a change to have it multiline but I find it change the UI, should I keep it multiline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either that or change max width of tooltip to large value to avoid it overflowing
I would opt for increasing max width
Co-authored-by: Viki Val <viktorko99@gmail.com>
Code Climate has analyzed commit 99c09d4 and detected 0 issues on this pull request. View more on Code Climate. |
One tooltip still need to be migrated but is multilined
PR Type
Context
<b-tooltip />
component for nowMinting
componentBefore submitting pull request, please make sure:
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at 150d681
Refactored the minting UI and code to use Vue 3 composition API and remove unused components. Deleted
Tooltip.vue
and movedMinting.vue
logic toDropUpload.vue
. Simplified the minting settings and improved the code quality.🤖 Generated by Copilot at 150d681