Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: programmatic modal #6714

Merged
merged 12 commits into from
Aug 16, 2023
Merged

refactor: programmatic modal #6714

merged 12 commits into from
Aug 16, 2023

Conversation

preschian
Copy link
Member

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

@kodabot
Copy link
Collaborator

kodabot commented Aug 15, 2023

WARNING @preschian PR for issue #6277 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #6277

@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 32c3ad9
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64db5dc29857080008dbf8e0
😎 Deploy Preview https://deploy-preview-6714--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 15, 2023

AI-Generated Summary: This pull request includes several changes that primarily revolve around replacing instances of $buefy.modal.open with $neoModal.open and $neoModal.closeAll() across various Vue components. We can also see that an unnecessary import { BModalConfig } from 'buefy/types/components has been removed in multiple places. Furthermore, there is a creation of new file NeoModalExtend.vue and plugin.js under NeoModalExtend folder. Additionally, there are minor modifications to properties like changing of customClass to rootClass, and adding condition to close all the modals before opening a new one. In a nutshell, main purpose of these changes is to switch from using Buefy modal component to newly created NeoModalExtend component from Kodadot library, and to enhance the behaviors of modal opening and closing across the project.

@reviewpad reviewpad bot added the medium Pull request is medium label Aug 15, 2023
@preschian preschian mentioned this pull request Aug 15, 2023
37 tasks
@preschian preschian marked this pull request as ready for review August 15, 2023 09:41
@preschian preschian requested a review from a team as a code owner August 15, 2023 09:41
@preschian preschian requested review from vikiival and Jarsen136 and removed request for a team August 15, 2023 09:41
@preschian preschian marked this pull request as draft August 15, 2023 09:55
@reviewpad reviewpad bot added large Pull request is large and removed medium Pull request is medium labels Aug 15, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 15, 2023

Code Climate has analyzed commit 32c3ad9 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@preschian preschian marked this pull request as ready for review August 15, 2023 11:17
@preschian preschian requested review from roiLeo and prury August 15, 2023 11:21
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Even if we are going to rework this after migration.

Otherwise I can't open shopping cart & notification on mobile (maybe it isn't related with this PR, works on beta)

components/Navbar.vue Show resolved Hide resolved
components/Navbar.vue Show resolved Hide resolved
@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Aug 15, 2023
@prury
Copy link
Member

prury commented Aug 15, 2023

So far:

Navbar ✔️

drop:
DropContainer - ✔️
TokenImportButton - could not find

unlockable:
UnlockableContainer.vue ✔️

Connect Wallet:
ConnectWalletModal.vue ✔️
useConnectWallet.ts ✔️

NotificationBox:
useNotificationBox.ts ✔️

ShoppingCart ✔️
ShoppingCartModal.vue ✔️

GalleryItem:
GalleryItemOffer.vue ✔️

Navbar:
NotificationBoxButton.vue ✔️
ProfileDropdown.vue ✔️
ShoppingCartButton.vue ✔️

redirect:
useRedirectModal.ts (how can i test this? is it a singular to kodadot link converter?)

RMRK/Gallery
EmotionList.vue (not being used, right?)
GalleryCard.vue ✔️

Shared:
ConnectWalletButton.vue ✔️

went trough the ones i could with the knowledge i have, lmk if missed something

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 15, 2023
@yangwao
Copy link
Member

yangwao commented Aug 16, 2023

pay 100 usd

@yangwao
Copy link
Member

yangwao commented Aug 16, 2023

😍 Perfect, I’ve sent the payout
💵 $100 @ 4.79 USD/DOT ~ 20.877 $DOT
🧗 1xjvRADwdJcnmUCLWerEHR4iGCT5EBTm4D4fzLLg4LcAC9p
🔗 0x5956899f54cc1ec1dae3ef1ada2fd096db173e30ab24bb2176b8992b4484ab8c

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 16, 2023
@yangwao yangwao merged commit 3405355 into main Aug 16, 2023
11 checks passed
@yangwao yangwao deleted the refactor/programmatic-modal branch August 16, 2023 06:29
This was referenced Aug 16, 2023
@roiLeo roiLeo mentioned this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Programmatic Modal
6 participants