-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π STATEMINE Version Zero #5932
Conversation
# Conflicts: # package.json # pnpm-lock.yaml
# Conflicts: # utils/prefix.ts # utils/queryPathResolver.ts
# Conflicts: # libs/static/src/endpoints.ts # utils/chain.ts
@@ -50,4 +54,13 @@ export function execListTx(item: ActionList, api, executeTransaction) { | |||
errorMessage: item.errorMessage, | |||
}) | |||
} | |||
|
|||
if (item.urlPrefix === 'stmn') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
] | ||
|
||
export const chainInfo = { | ||
export const chainInfo: Record<Prefix, string> = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 3 locations. Consider refactoring.
components/stmn/Create/utils.ts
Outdated
return token === 'KSM' ? depositInKSM : ksmToBsx(depositInKSM) | ||
} | ||
|
||
export const getFeesToken = async (): Promise<Token> => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identical blocks of code found in 2 locations. Consider refactoring.
@@ -0,0 +1,7 @@ | |||
<template> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
who's this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Placeholder for new create design
|
||
watch(newCollectionId, (id) => { | ||
if (id) { | ||
executeTransaction({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 6 locations. Consider refactoring.
|
||
const args = [[create, meta, ...list]] | ||
|
||
executeTransaction({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 6 locations. Consider refactoring.
import { constructMeta } from './constructMeta' | ||
import { useNewCollectionId } from './useNewCollectionId' | ||
|
||
export async function execMintCollectionStatemine( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function execMintCollectionStatemine
has 29 lines of code (exceeds 25 allowed). Consider refactoring.
import type { ActionMintToken, MintedCollectionBasilisk } from '../types' | ||
import { constructMeta } from './constructMeta' | ||
|
||
export async function execMintStatemine( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function execMintStatemine
has 31 lines of code (exceeds 25 allowed). Consider refactoring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's about this π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 5653 lines exceeds the maximum allowed for the inline comments feature.
@kodadot/internal-dev any ideas why it does not build? π₯Ί |
No dependency changes detected. Learn more about Socket for GitHub βοΈ π No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 5653 lines exceeds the maximum allowed for the inline comments feature.
maybe comming from your push of |
try your luck and update to pnpm8 |
Build OK on my side β Generated public dist nitro 12:24:37
βΉ Initializing prerenderer nitro 12:24:37
βΉ Prerendering 47 initial routes with crawler nitro 12:24:38
ββ / (24ms) nitro 12:24:38
ββ /200 (2ms) nitro 12:24:38
ββ /404 (1ms) nitro 12:24:38
ββ /about (1ms) nitro 12:24:38
ββ /carbonless (1ms) nitro 12:24:38
ββ /contribute (1ms) nitro 12:24:38
ββ /e2e-login (1ms) nitro 12:24:38
ββ /error (2ms) nitro 12:24:38
ββ /esCarbonless (1ms) nitro 12:24:38
ββ /esSustainability (4ms) nitro 12:24:38
ββ /first-time (1ms) nitro 12:24:38
ββ /hot (1ms) nitro 12:24:38
ββ /identity (1ms) nitro 12:24:38
ββ /jobs (1ms) nitro 12:24:38
ββ /partnership (1ms) nitro 12:24:38
ββ /qrCode (0ms) nitro 12:24:38
ββ /sales (1ms) nitro 12:24:38
ββ /series-insight (1ms) nitro 12:24:38
ββ /settings (2ms) nitro 12:24:38
ββ /spotlight (0ms) nitro 12:24:38
ββ /sustainability (1ms) nitro 12:24:38
ββ /teleport (1ms) nitro 12:24:38
ββ /teleport-bridge (0ms) nitro 12:24:38
ββ /transfer (1ms) nitro 12:24:38
ββ /transform (3ms) nitro 12:24:38
ββ /tutorials (1ms) nitro 12:24:38
ββ /bsx/assets (0ms) nitro 12:24:38
ββ /bsx/claim (1ms) nitro 12:24:38
ββ /bsx/create (1ms) nitro 12:24:38
ββ /bsx/incomingOffers (0ms) nitro 12:24:38
ββ /bsx/offers (1ms) nitro 12:24:38
ββ /bsx/stats (1ms) nitro 12:24:38
ββ /bsx/waifu (0ms) nitro 12:24:38
ββ /ksm/create (1ms) nitro 12:24:38
ββ /rmrk/admin (0ms) nitro 12:24:38
ββ /rmrk/create (1ms) nitro 12:24:38
ββ /rmrk/credit (1ms) nitro 12:24:39
ββ /rmrk/mint (1ms) nitro 12:24:39
ββ /snek/assets (1ms) nitro 12:24:39
ββ /snek/claim (1ms) nitro 12:24:39
ββ /snek/create (0ms) nitro 12:24:39
ββ /snek/incomingOffers (2ms) nitro 12:24:39
ββ /snek/offers (1ms) nitro 12:24:39
ββ /snek/stats (1ms) nitro 12:24:39
ββ /snek/waifu (0ms) nitro 12:24:39
ββ /stmn/create/collection (1ms) nitro 12:24:39
ββ /stmn/create/item (0ms) nitro 12:24:39
β You can now deploy dist to any static hosting! |
Loooks like nft-gallery is two times there, but I do not know how it appeared there |
Code Climate has analyzed commit 7f7cad9 and detected 10 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
continue in #5935 |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
π __ Let's make a quick check before the contribution.
PR Type
Context
Integration of statemine:
What should you know
We have of course new indexer called stick
We are missing minting (on-chain code is there and I started to rewrite it with new design)
Screenshot πΈ
Copilot Summary
π€ Generated by Copilot at baa480b
Added support for Statemine chain and its features, such as creating and buying NFTs, to the gallery. Updated various components, composables, and static files to handle Statemine transactions and data. Added new components and files for the Statemine create feature. Fixed some minor issues and improved code style and readability.
π€ Generated by Copilot at baa480b