Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 STATEMINE v0 #5935

Merged
merged 55 commits into from
May 13, 2023
Merged

🎉 STATEMINE v0 #5935

merged 55 commits into from
May 13, 2023

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented May 12, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Copilot Summary

🤖 Generated by Copilot at 878a6df

This pull request integrates the Statemine chain into the app, adding support for creating, buying, selling, sending, and burning NFTs on the chain. It also improves the performance and usability of some components, and updates the static package and its dependencies. The main files affected are components/gallery/GalleryItemAction/GalleryItemActionType/GalleryItemBuy.vue, components/stmn/Create/CreateCollection.vue, and libs/static/src/chains.ts.

🤖 Generated by Copilot at 878a6df

Sing, O Muse, of the mighty deeds of the kodadot team,
Who forged a path for the Statemine chain, the new realm of NFTs,
With skill and craft they shaped the code, the mimeType and the CreateCollection,
And made the GalleryItemOffers shine like the stars of the night.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 12, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request


watch(newCollectionId, (id) => {
if (id) {
executeTransaction({
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 6 locations. Consider refactoring.

import { constructMeta } from './constructMeta'
import { useNewCollectionId } from './useNewCollectionId'

export async function execMintCollectionStatemine(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function execMintCollectionStatemine has 29 lines of code (exceeds 25 allowed). Consider refactoring.

import type { ActionMintToken, MintedCollectionBasilisk } from '../types'
import { constructMeta } from './constructMeta'

export async function execMintStatemine(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function execMintStatemine has 31 lines of code (exceeds 25 allowed). Consider refactoring.

@vikiival vikiival mentioned this pull request May 12, 2023
5 tasks
@vikiival
Copy link
Member Author

Cannot find module '/home/runner/work/nft-gallery/nft-gallery/node_modules/@kodadot1/static/dist/index.cjs'

Somehow I still get this weird dual routes

@yangwao
Copy link
Member

yangwao commented May 12, 2023

Let's make issues for refactor and if @kodadot/qa-guild approves it at some extent, happy to merge v0

@yangwao yangwao added the A-statemine-ahk related for statemine common chain, under new name Asset Hub Kusama label May 12, 2023
@yangwao yangwao changed the title Stmn v zero 🎉 Stmn v zero May 12, 2023
@vikiival vikiival changed the title 🎉 Stmn v zero 🎉 STATEMINE v0 May 12, 2023
@prury
Copy link
Member

prury commented May 12, 2023

  • Interface seems good
  • Statemine chain selection working properly
  • Some items are not loading properly when trying to see the available collections:
    images not loading properly
    Items:
    itens not loading properly

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label May 12, 2023
@yangwao
Copy link
Member

yangwao commented May 12, 2023

  • Some items are not loading properly when trying to see the available collections:

can you create separate issue with those collection so we can have a look once this is merged? Thanks! :)

@prury
Copy link
Member

prury commented May 12, 2023

  • Some items are not loading properly when trying to see the available collections:

can you create separate issue with those collection so we can have a look once this is merged? Thanks! :)

done, #5940

@vikiival
Copy link
Member Author

There are still some picutures that are uploading to the gateway

Screenshot 2023-05-12 at 21 25 47

@codeclimate
Copy link

codeclimate bot commented May 13, 2023

Code Climate has analyzed commit cc8bbb4 and detected 10 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3
Duplication 7

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented May 13, 2023

Resolving conflicts of code I don't undestand, playing doctor. Let's see if it's builds.

Made follow up for refactor

@yangwao
Copy link
Member

yangwao commented May 13, 2023

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-statemine-ahk related for statemine common chain, under new name Asset Hub Kusama large Pull request is large S-changes-requested-🤞 PR is almost good to go, just some fine tunning waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants