-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update components to be more seo compatible - lighthouse #6844
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request focuses on improving the SEO compatibility of the website. Changes are made across three Vue components: TheFooter.vue, SearchLanding.vue, and ShoppingCartButton.vue. In TheFooter.vue, the clickable list items directing to social URLs have been updated to use |
@thnaylor waiting because of this? |
Updated it now. 😄 |
Code Climate has analyzed commit c016fde and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smoll
@@ -29,8 +29,9 @@ | |||
<a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we stay on Kodadot app I would change it to <nuxt-link />
it's always good to try it in incognito as extension can slow down and inject things or in fresh new chrome profile best |
oh, ok, ty, will do! |
@prury I had a look and noticed that netlify deployment urls is blocking indexing. Found this text when researching about this issue: 🤷
|
allright, ty! |
Co-authored-by: roiLeo <medina.leo42@gmail.com>
let's try |
pay 50 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
nice job @thnaylor ! |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
Did your issue had any of the "$" label on it?
Comment
Lighthouse
Copilot Summary
🤖 Generated by Copilot at f52d6e0
Improved the footer components and the shopping cart button for better usability, accessibility, and SEO. Used
href
attributes for links and changed some HTML elements.🤖 Generated by Copilot at f52d6e0