Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update components to be more seo compatible - lighthouse #6844

Merged
merged 5 commits into from
Aug 21, 2023

Conversation

thnaylor
Copy link
Contributor

@thnaylor thnaylor commented Aug 20, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

Comment

  • Some ways I've managed to achieve 100% SEO score in lighthouse for the landing page, however it was mostly experimental changes sowill be good to hear comments & suggestions from other contributers if any.

Lighthouse

Desktop Mobile
image image

Copilot Summary

🤖 Generated by Copilot at f52d6e0

Improved the footer components and the shopping cart button for better usability, accessibility, and SEO. Used href attributes for links and changed some HTML elements.

🤖 Generated by Copilot at f52d6e0

href for links
better for users and SEO
autumn leaves fall fast

@kodabot
Copy link
Collaborator

kodabot commented Aug 20, 2023

WARNING @thnaylor PR for issue #6839 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #6839

@netlify
Copy link

netlify bot commented Aug 20, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 98839dd
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64e397d9eea24d00084456b8
😎 Deploy Preview https://deploy-preview-6844--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 20, 2023

AI-Generated Summary: This pull request focuses on improving the SEO compatibility of the website. Changes are made across three Vue components: TheFooter.vue, SearchLanding.vue, and ShoppingCartButton.vue. In TheFooter.vue, the clickable list items directing to social URLs have been updated to use <a> tags with href attributes instead of directly initiating a window.open on click. For SearchLanding.vue, the chain selection option now uses an href to indicate selection along with the existing click event. The ShoppingCartButton.vue has had its wrapping element changed from <a> to <div> to more accurately represent its behavior. These changes enhance search engine optimization by improving the structure and accessibility of the website's HTML content.

@reviewpad reviewpad bot added the small Pull request is small label Aug 20, 2023
@thnaylor thnaylor changed the title fix: update conponents to be more seo compatible - lighthouse fix: update components to be more seo compatible - lighthouse Aug 21, 2023
@yangwao
Copy link
Member

yangwao commented Aug 21, 2023

Security Hotspot E 2 Security Hotspots

@thnaylor waiting because of this?

@thnaylor
Copy link
Contributor Author

Security Hotspot E 2 Security Hotspots

@thnaylor waiting because of this?

Updated it now. 😄

@codeclimate
Copy link

codeclimate bot commented Aug 21, 2023

Code Climate has analyzed commit c016fde and detected 0 issues on this pull request.

View more on Code Climate.

@thnaylor thnaylor marked this pull request as ready for review August 21, 2023 14:07
@thnaylor thnaylor requested a review from a team as a code owner August 21, 2023 14:07
@thnaylor thnaylor requested review from roiLeo and daiagi and removed request for a team August 21, 2023 14:07
@prury
Copy link
Member

prury commented Aug 21, 2023

why am i getting worse SEO scores in the deployed version? am i doing something wrong? (analyzing only mobile SEO)

canary deployed
image image

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smoll

components/landing/SearchLanding.vue Outdated Show resolved Hide resolved
@@ -29,8 +29,9 @@
<a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we stay on Kodadot app I would change it to <nuxt-link />

@yangwao
Copy link
Member

yangwao commented Aug 21, 2023

why am i getting worse SEO scores in the deployed version? am i doing something wrong? (analyzing only mobile SEO)

it's always good to try it in incognito as extension can slow down and inject things or in fresh new chrome profile best

@prury
Copy link
Member

prury commented Aug 21, 2023

why am i getting worse SEO scores in the deployed version? am i doing something wrong? (analyzing only mobile SEO)

it's always good to try it in incognito as extension can slow down and inject things or in fresh new chrome profile best

oh, ok, ty, will do!

@thnaylor
Copy link
Contributor Author

@prury I had a look and noticed that netlify deployment urls is blocking indexing.

image

Found this text when researching about this issue: 🤷

"Tip: One thing to note is that Netlify will automatically set an HTTP response header of X-robots-tag: noindex for preview deployments. This prevents any preview site from being index by a web crawler!"

@prury
Copy link
Member

prury commented Aug 21, 2023

@prury I had a look and noticed that netlify deployment urls is blocking indexing.

image

Found this text when researching about this issue: 🤷

"Tip: One thing to note is that Netlify will automatically set an HTTP response header of X-robots-tag: noindex for preview deployments. This prevents any preview site from being index by a web crawler!"

allright, ty!

Co-authored-by: roiLeo <medina.leo42@gmail.com>
@yangwao
Copy link
Member

yangwao commented Aug 21, 2023

let's try

@yangwao
Copy link
Member

yangwao commented Aug 21, 2023

pay 50 usd

@yangwao yangwao merged commit c4baf33 into kodadot:main Aug 21, 2023
8 of 9 checks passed
@yangwao
Copy link
Member

yangwao commented Aug 21, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 4.39 USD/DOT ~ 11.39 $DOT
🧗 123PCJXhjb15i6JwVVRGd7KvN2sSNZrtPjr5doJq9oWctoTt
🔗 0xbbdb011a87c2b7efc7983743c7c70c724f3ddfc6a2d3a38aa9fd88478c607fa1

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 21, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@prury
Copy link
Member

prury commented Aug 21, 2023

Mobile Desktop
image image

nice job @thnaylor !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to landing page SEO
5 participants