Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update components to be more seo compatible - lighthouse #6844

Merged
merged 5 commits into from
Aug 21, 2023
Merged

fix: update components to be more seo compatible - lighthouse #6844

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f52d6e0
fix: update conponents to be more seo compatible - lighthouse
thnaylor Aug 20, 2023
d9b1e91
Merge branch 'main' into fix/6839
thnaylor Aug 20, 2023
85f10d1
fix: updated href to v-safe-html
thnaylor Aug 21, 2023
c016fde
Merge branch 'main' into fix/6839
thnaylor Aug 21, 2023
98839dd
Update components/landing/SearchLanding.vue
yangwao Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions components/TheFooter.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,12 @@
<li
v-for="item in socials"
:key="item.url"
class="footer-container-socials-list-item is-flex is-align-items-center is-justify-content-center mr-2"
@click="goToSocials(item.url)">
class="footer-container-socials-list-item is-flex is-align-items-center is-justify-content-center mr-2">
<a
v-safe-href="item.url"
class="is-flex icon"
rel="nofollow noopener noreferrer"
target="_blank"
role="link"
:aria-label="item.name">
<!-- substack doesnt have a font awesome icon -->
Expand Down Expand Up @@ -274,7 +275,4 @@ const socials = [
icon: 'reddit-alien',
},
]
const goToSocials = (url): void => {
window.open(url, '_blank')
}
</script>
6 changes: 4 additions & 2 deletions components/landing/SearchLanding.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@
<a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we stay on Kodadot app I would change it to <nuxt-link />

v-for="chain in availableChains"
:key="chain.value"
v-safe-href="`/${chain.value}/explore/collectibles`"
:class="['m-2', 'chain-option active']"
@click="switchChain(chain.value)">
@click="switchChain(chain.value, $event)">
yangwao marked this conversation as resolved.
Show resolved Hide resolved
{{ chainText(chain.text) }}
<sup v-if="chain.text.includes('[Beta]')" class="beta-text is-size-7">
{{ $t('beta') }}</sup
Expand Down Expand Up @@ -74,7 +75,8 @@ const landingImage = computed(() => {
}
})

const switchChain = (value) => {
const switchChain = (value, event) => {
event.preventDefault()
if (value !== urlPrefix.value) {
setUrlPrefix(value)
}
Expand Down
4 changes: 2 additions & 2 deletions components/navbar/ShoppingCartButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<a
<div
class="navbar-item is-flex is-align-items-center"
@click="toggleShoppingCartModal">
<span v-if="props.showLabel">{{ $t('shoppingCart.label') }}</span>
Expand All @@ -14,7 +14,7 @@
rounded
class="count-position is-size-7" />
</div>
</a>
</div>
</template>

<script setup lang="ts">
Expand Down