-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: execMintStatemine and execMintStatemine #6928
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request primarily refactors the |
status.value = 'loader.ipfs' | ||
const args = await getArgs(item, api) | ||
|
||
const nameInNotifications = Array.isArray(item.token) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identical blocks of code found in 2 locations. Consider refactoring.
@@ -22,3 +22,38 @@ export const calculateFees = () => { | |||
|
|||
return { enabledFees, feeMultiplier } | |||
} | |||
|
|||
export const transactionFactory = (getArgs) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function transactionFactory
has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Reviewpad Report
|
Solving 2 code climate issues, code climate raises 3 more issues 😄 |
hmm resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm 😊
Code Climate has analyzed commit 28d7f4b and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
great! |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
@floyd-li Hey, there is something broken here. |
sry my bad there's a constant naming issue. gonna make a quick pr for it. |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
to resolve this one:
👇 __ Let's make a quick check before the contribution.
PR Type
Context
Before submitting pull request, please make sure:
Optional
Did your issue had any of the "$" label on it?
Community participation
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at cd51297
Refactored the minting logic for Basilisk and Statemine tokens by using a common
transactionFactory
function. This reduced code duplication and improved readability. Added thetransactionFactory
function to./composables/transaction/mintToken/utils.ts
.🤖 Generated by Copilot at cd51297