Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: export const name issue #6976

Merged
merged 1 commit into from
Aug 26, 2023
Merged

fix: export const name issue #6976

merged 1 commit into from
Aug 26, 2023

Conversation

floyd-li
Copy link
Member

sry my bad error in export constant naming. just a quick small pr to fix this one so i do not use the common pr template.

@yangwao @vikiival @Jarsen136

image

@floyd-li Hey, there is something broken here.

Originally posted by @Jarsen136 in #6928 (comment)

@floyd-li floyd-li requested a review from a team as a code owner August 26, 2023 16:02
@floyd-li floyd-li requested review from stephenjason89 and daiagi and removed request for a team August 26, 2023 16:02
@netlify
Copy link

netlify bot commented Aug 26, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 2131577
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64ea222e4647d60008712a32
😎 Deploy Preview https://deploy-preview-6976--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 26, 2023

AI-Generated Summary: This pull request addresses an issue in the naming of an exported constant in the transactionMintBasilisk.ts file. It changes the name from execMintStatemine to execMintBasilisk to better align with the context of the file.

@reviewpad reviewpad bot added the small Pull request is small label Aug 26, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 26, 2023

Code Climate has analyzed commit 2131577 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 26, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@sonarcloud
Copy link

sonarcloud bot commented Aug 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Jarsen136 Jarsen136 added this pull request to the merge queue Aug 26, 2023
Merged via the queue into kodadot:main with commit 8baa23a Aug 26, 2023
15 checks passed
This was referenced Aug 30, 2023
Merged
Merged
@floyd-li floyd-li deleted the refactor/transactionFactory branch October 8, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daiagi daiagi daiagi approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@stephenjason89 stephenjason89 Awaiting requested review from stephenjason89 stephenjason89 is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@floyd-li @daiagi @Jarsen136