Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace use-clipboard with useClipboard #7095

Closed
wants to merge 23 commits into from
Closed

refactor: replace use-clipboard with useClipboard #7095

wants to merge 23 commits into from

Conversation

dxphilo
Copy link
Contributor

@dxphilo dxphilo commented Sep 1, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 088602c

Refactored the clipboard functionality across the app to use a custom useCopyClipboard composable based on @vueuse/core. Removed the vue-clipboard2 dependency and the vueClipboard plugin. Added toast messages and tooltips to improve user feedback when copying text. Improved code reuse and consistency for generating and copying shareable links.

🤖 Generated by Copilot at 088602c

To copy text with a click
We refactored our code quite a bit
We used useClipboard
And removed some old libs
And added some toast and tooltip

@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 088602c
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64f1fdea0ab65d0008e4c148
😎 Deploy Preview https://deploy-preview-7095--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added the medium Pull request is medium label Sep 1, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 1, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@codeclimate
Copy link

codeclimate bot commented Sep 1, 2023

Code Climate has analyzed commit 088602c and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo
Copy link
Contributor

roiLeo commented Sep 1, 2023

duplicate #7064? please could you open merge request on nuxt branch

@dxphilo dxphilo changed the base branch from main to nuxt September 1, 2023 15:13
@reviewpad reviewpad bot added large Pull request is large and removed medium Pull request is medium labels Sep 1, 2023
@dxphilo
Copy link
Contributor Author

dxphilo commented Sep 1, 2023

duplicate #7064? please could you open merge request on nuxt branch

Yeah seems like a duplicate, Ill just close this

@dxphilo dxphilo closed this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants