Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Nuxt3 plugins #5314

Closed
17 of 20 tasks
roiLeo opened this issue Mar 21, 2023 · 8 comments
Closed
17 of 20 tasks

Refactor: Nuxt3 plugins #5314

roiLeo opened this issue Mar 21, 2023 · 8 comments
Labels
$$ ~51-150usd A-nuxt A-refactoring Refactoring stuff, make code more readable, mitigating tech debt A-vue3 chief hacktoberfest p1 preventing everyone from using app

Comments

@roiLeo
Copy link
Contributor

roiLeo commented Mar 21, 2023

All plugins in your plugins/ directory are auto-registered, so you should not add them to your nuxt.config

.client suffix in the file name to load a plugin only on the client side.

export default defineNuxtPlugin(nuxtApp => {
  // Doing something with nuxtApp
})

Done

Todo

@roiLeo roiLeo added p3 non-core, affecting less than 40% A-refactoring Refactoring stuff, make code more readable, mitigating tech debt labels Mar 21, 2023
@yangwao yangwao added $ ~<50usd p2 core functionality, or is affecting 60% of app chief and removed p3 non-core, affecting less than 40% labels Aug 29, 2023
@yangwao yangwao mentioned this issue Aug 29, 2023
18 tasks
@yangwao yangwao added p1 preventing everyone from using app and removed p2 core functionality, or is affecting 60% of app labels Aug 30, 2023
@pbkompasz
Copy link
Contributor

👋

@kodabot
Copy link
Collaborator

kodabot commented Aug 30, 2023

ASSIGNED - @pbkompasz 🔒 LOCKED -> Thursday, August 31st 2023, 12:26:56 UTC -> 24 hours

@yangwao
Copy link
Member

yangwao commented Aug 30, 2023

👋

all of them @pbkompasz ?
I think rather write which part you want to take :)

@pbkompasz
Copy link
Contributor

@yangwao I have refactored a couple already. Here is the current status:

I do have a couple of questions:

  1. the endpoint plugin is just a simple import, do we need that?
  2. polkadot, globalVariables and pwa are already exporting a default function. Should those be also refactored or are they good currently?
  3. The plugins are not being auto-registered.

@kodabot
Copy link
Collaborator

kodabot commented Aug 31, 2023

ASSIGNMENT EXPIRED - @pbkompasz has been unassigned.

@pbkompasz pbkompasz mentioned this issue Sep 1, 2023
16 tasks
@yangwao yangwao added $$ ~51-150usd A-nuxt A-vue3 and removed $ ~<50usd labels Sep 1, 2023
@roiLeo
Copy link
Contributor Author

roiLeo commented Sep 1, 2023

so far so good, most plugins have been fixed.

what's missing:

  • consola
  • pwa
  • download
  • image preview

lmk which one you take

done:

@pbkompasz
Copy link
Contributor

@roiLeo What about notifications. Should that be converted into a plugin? It is used by clipboard and it is commented out in the nuxt branch.

@roiLeo
Copy link
Contributor Author

roiLeo commented Sep 6, 2023

@pbkompasz ref #7083 (comment), @preschian might takes care of it. But feel free to open PR if you want to fix it asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$$ ~51-150usd A-nuxt A-refactoring Refactoring stuff, make code more readable, mitigating tech debt A-vue3 chief hacktoberfest p1 preventing everyone from using app
Projects
None yet
Development

No branches or pull requests

4 participants