Nuxt3 - merging strategy

[yangwao]

Things to be done

• Nuxt3 - Encountered problems list #7375
• Nuxt - Transaction related problems #7403
• https://github.com/GrabarzUndPartner/nuxt-speedkit-example/pull/87#issuecomment-1713495884

Done

• From Towards Vue 3 / Nuxt 3 migration roadmap #2690 (comment)
• upgrade to nuxt3, remove nuxt-bridge & edge
• remove webpack
• upgrade i18
• upgrade @nuxtjs/apollo
• update layouts & page with vue3 composition (<NuxtLayout><NuxtPage /></NuxtLayout> & definePageMeta)
• rename /static folder to /public
• Reduce using nuxt-property-decorator and use composition API #4750 - two components remaining
• upgrade i18 Refactor: i18n module #3916
• Programmatic Modal #6277 : major need
• programmatic notification, tooltip
• Packages migration audit #6911 : devs can handle package migration, (partially done)
• Fix GraphQL calls in Nuxt3 #7225
• Update sub-api package #6931 (⬆️ sub-api package #7304)
• Refactor: Nuxt3 plugins #5314 one by one (some of them have been made) link
• Nuxt3 - merging strategy #7034 (comment)

Deployment

• Commit your PR against nuxt branch
• Deployment is available at nuxt.kodadot.xyz

Originally posted by @roiLeo in #6917 (comment)

[stephenjason89]

@roiLeo Hi, yeah managed to fix i18n just now.
Should i make a pull request to the same branch?

I added a simple select box on the default layout so you can test.

Here's the PR for it.
roiLeo#27 😄

[stephenjason89]

Hello @roiLeo, here's the new PR for i18n. Everything seems to be working. Also migrated some webpack functions to vite.
#7045

[roiLeo]

Update

What's missing:

• GalleryItem Carousel
• Landing Carousel (infinite loading image issue)
• SearchBar component fix (Nuxt3 #7290)
• /blog pages (💅 Nuxt 3 Blog Content #7313)
• consola plugin (fix: [nuxt3] consola as a plugin #7411)
• Test Tx (mint, ✅ buy, ✅ list, ✅ offers etc..) Tested on /snek/gallery/2509719727-5

[yangwao]

@roiLeo why is nuxt-speedkit striked?

[roiLeo]

@roiLeo why is nuxt-speedkit striked?

It doesn't block nuxt3 migration we can do it in a latter stage

[yangwao]

We are thinking w/ @vikiival that we would close all outstanding PRs towards main branch and start looking forward to others pushing fixes towards nuxt branch, so we can flawlessly switch and enjoy sweet ride of Nuxt3

lmk what do you think @roiLeo as I see, there is consola and test tx issues outstanding.

I think @prury can check those TXs for now and once consola will be there, we can proceed.

[roiLeo]

We are thinking w/ @vikiival that we would close all outstanding PRs towards main branch and start looking forward to others pushing fixes towards nuxt branch, so we can flawlessly switch and enjoy sweet ride of Nuxt3

As you guys want, we haven't spotted all the new bugs yet. Imo we're at around 85-90% completed on Nuxt3.
I would first merge hotfix, do a release, and have more people to test/fix new app.

lmk what do you think @roiLeo as I see, there is consola and test tx issues outstanding.

consola, tests, tx, preview, download, sitemap, $seoMeta, useVModel, infinite console error in MediaItem and maybe more?

[vikiival]

As you guys want, we haven't spotted all the new bugs yet. Imo we're at around 85-90% completed on Nuxt3.

Just around the time to dedicate force there ☺️

I would first merge hotfix, do a release, and have more people to test/fix new app.

So starting tomorrow unless it is not a hotfix/bugfix/p1 it will be closed

[yangwao]

we're at around 85-90% completed on Nuxt3.

good around sweet spot to transition

consola, tests, tx, preview, download, sitemap, $seoMeta, useVModel, infinite console error in MediaItem

it's about how we will split the load with the rest of the team. I'm pretty optimistic under 2 weeks since working on those things we can run recent plugins and packages

[roiLeo]

Please take a break of adding new (large) features as I keep having loads of new conflicts/work

[vikiival]

As agreed yesterday unless it is not a hot fix you can close it

[yangwao]

Please take a break of adding new (large) features as I keep having loads of new conflicts/work

I was thinking today, I would

• switch base branch to nuxt -> new PRs going there
• merge current PRs and push new release
• focus for the upcoming 2 weeks on making nuxt production ready
• in case of a bigger bug, pushing from the main out
• when - Nuxt3 - Encountered problems list #7375 will be doable short, get green light and not really bad UX, I would merge nuxt -> main
• push it out
• get back in flywheel as usual

[vikiival]

merge current PRs and push new release

Merge fixes imo 🥹. Others can be meeged to nuxt3 later

[preschian]

We are thinking w/ @vikiival that we would close all outstanding PRs towards main branch and start looking forward to others pushing fixes towards nuxt branch, so we can flawlessly switch and enjoy sweet ride of Nuxt3

Please take a break of adding new (large) features as I keep having loads of new conflicts/work

So starting tomorrow unless it is not a hotfix/bugfix/p1 it will be closed

ooohhh 😮, sorry I missed this announcement. just saw it today

so, we freeze features targeting to the main branch? if said so, I can close this PR and PR

because I still see new PR targeting the main branch

[yangwao]

Merge fixes imo 🥹. Others can be meeged to nuxt3 later

Which one?

Merged those which did not have conflicts; we can still merge once a few are resolved and do release

Meanwhile

Default branch changed to nuxt

so, we freeze features targeting to the main branch? if said so, I can close this #7395 and #7394

@preschian if it's not critical or p1,p2 bug, I would push it to nuxt

[yangwao]

I would like to see a focus on

• Nuxt - Transaction related problems #7403

We plan to set it to production next week to have this out, as we did not have significant release updates for a while for main and I believe at the current stage it's already a major UX upgrade for the end user

[yangwao]

It seems everything is back to main !

Nuxt3 available at https://nuxt.kodadot.xyz

Thank you to all contributors, @kodadot/internal-dev and individuals.

Let's do final checks to see if anything is missing before the release to production