Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💅 Nuxt 3 Blog Content #7313

Merged
merged 3 commits into from
Sep 21, 2023
Merged

💅 Nuxt 3 Blog Content #7313

merged 3 commits into from
Sep 21, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Sep 21, 2023

Nuxt 3 Blog content (/blog)

This is fun 🏂

@roiLeo roiLeo requested a review from a team as a code owner September 21, 2023 12:07
@roiLeo roiLeo requested review from preschian and floyd-li and removed request for a team September 21, 2023 12:07
@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for nuxt-kodadot ready!

Name Link
🔨 Latest commit d5b3f4e
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-kodadot/deploys/650c325236a36e0008c4524f
😎 Deploy Preview https://deploy-preview-7313--nuxt-kodadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 21, 2023

AI-Generated Summary: This pull request includes several changes aiming at improvements in a NuxtJS and Vue.js application. In the nuxt.config.js file, the 'service-worker' preset for Nitro settings was added, and a new NuxtJS module @nuxt/content was introduced to manage content files efficiently.

The BlogPost.vue component has been refactored for streamline data access and reducing code redundancy. The attributes object was replaced with a post object from a direct content query and the importing step to fetch post details was eliminated. Moreover, the component singlePostComponent was replaced by the ContentDoc component, and references made to attributes in the Vue template were rerouted to the new post object.

Changes in the pages/blog/index.vue file include a shift from the post.attributes.<attribute> to direct post.<attribute> approach, departed from method-based permalink to direct reference, and altered the Vue export default syntax to the <script setup> syntax and TypeScript. Further, the asyncData method has been replaced by queryContent('/').find() with a reactive useAsyncData() hook resulting in more maintainable code.

Lastly, in the package.json file, the @nuxt/content package has been added as a new dependency, which can potentially offer additional features or fix existing issues.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Sep 21, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 21, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@roiLeo roiLeo mentioned this pull request Sep 21, 2023
18 tasks
@roiLeo
Copy link
Contributor Author

roiLeo commented Sep 21, 2023

I'll merge it thanks

@roiLeo roiLeo merged commit 5d162e0 into kodadot:nuxt Sep 21, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant