Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: notification on nuxt3 #7247

Merged
merged 1 commit into from
Sep 12, 2023
Merged

refactor: notification on nuxt3 #7247

merged 1 commit into from
Sep 12, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented Sep 12, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Screenshot 📸

  • My fix has changed UI

Copilot Summary

🤖 Generated by Copilot at 2115999

This pull request replaces the Oruga UI notification plugin with custom wrappers from the @kodadot1/brick library, and enhances the landing page component with notification functionality. It also removes unused plugins and updates the useProgrammatic and useToast composable functions.

🤖 Generated by Copilot at 2115999

useProgrammatic
Toast notifications with brick
Oruga UI gone

@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for nuxt-kodadot ready!

Name Link
🔨 Latest commit 2115999
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-kodadot/deploys/650044810b035000073f4bd7
😎 Deploy Preview https://deploy-preview-7247--nuxt-kodadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 12, 2023

AI-Generated Summary: This pull request mainly involves a refactor for notifications in nuxt3. It adds import statements to the LandingPage.vue component to handle new notification messages and also modifies the composables files. The useProgrammatic.ts and useToast.ts underwent changes to enable new notifications. In the NeoNotificationNotice.vue component, modifications mainly revolved around extending the implementations. There is also a switch from JavaScript to TypeScript with the removal of plugin.js and the addition of plugin.ts in the NeoNotification component. Lastly, the nuxt.config.js file had some lines commented out and two plugin files, oruga-modal.ts and oruga-notification.ts have been deleted. Overall, this patch introduces 101 insertions and 95 deletions across 9 files.

@reviewpad reviewpad bot added the medium Pull request is medium label Sep 12, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 12, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@preschian preschian marked this pull request as ready for review September 12, 2023 11:02
@preschian preschian requested a review from a team as a code owner September 12, 2023 11:02
@preschian preschian requested review from stephenjason89 and roiLeo and removed request for a team September 12, 2023 11:02
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add oruga as plugin?

@preschian
Copy link
Member Author

preschian commented Sep 12, 2023

No need to add oruga as plugin?

seems like, so far no need, the diff is minimal on the usage side
from const { $neoNotification } = useNuxtApp() to const { neoNotification } = useProgrammatic()

@roiLeo
Copy link
Contributor

roiLeo commented Sep 12, 2023

let's go 🏎️

@roiLeo roiLeo merged commit 040bd5a into nuxt Sep 12, 2023
11 checks passed
@roiLeo roiLeo deleted the refactor/notification-nuxt3 branch September 12, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants