Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ sub-api package #7304

Merged
merged 3 commits into from
Sep 22, 2023
Merged

⬆️ sub-api package #7304

merged 3 commits into from
Sep 22, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Sep 19, 2023 •
edited
Loading

⚠️ didn't tested it yolo

#7304 (comment)

@roiLeo roiLeo requested a review from a team as a code owner September 19, 2023 14:47
@roiLeo roiLeo requested review from preschian and daiagi and removed request for a team September 19, 2023 14:47
@netlify
Copy link

netlify bot commented Sep 19, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 061ae18
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/650d92e0659bf50008c59617
😎 Deploy Preview https://deploy-preview-7304--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 19, 2023

AI-Generated Summary: This pull request includes changes in three files viz., Transfer.vue, package.json, and pnpm-lock.yaml. In the Transfer.vue file, the import statement for the Connector is replaced by the ApiFactory from '@kodadot1/sub-api' and the usage of the imported instance is accordingly updated. The other major change is in the package.json and pnpm-lock.yaml files where the version of '@kodadot1/sub-api' has been updated from "^0.1.2" to "0.2.0-rc.0". The dependencies of '@kodadot1/sub-api' are also updated and adjusted in the pnpm-lock.yaml file.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Sep 19, 2023
@roiLeo roiLeo mentioned this pull request Sep 21, 2023
Closed
18 tasks
@daiagi
Copy link
Contributor

daiagi commented Sep 22, 2023 •
edited
Loading

seems not working
step 1:
image

click continue aaanndd:
image

works normally on canary

@daiagi daiagi added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Sep 22, 2023
@roiLeo
Copy link
Contributor Author

roiLeo commented Sep 22, 2023

seems not working

weird it worked for me
https://kusama.subscan.io/extrinsic/0x9f7cca1512d26d7c4a144741e31f82950fd35435548889149e60409c6e8da361

Screenshot 2023-09-22 at 09-49-58 KodaDot - NFT Market Explorer

could you share more infos on how to reproduce it?

@codeclimate
Copy link

codeclimate bot commented Sep 22, 2023

Code Climate has analyzed commit 50556ff and detected 0 issues on this pull request.

View more on Code Climate.

@daiagi
Copy link
Contributor

daiagi commented Sep 22, 2023

weird. working fine now
maybe it's related to balance bug (need to open wallet modal for balance to update)

@daiagi daiagi removed the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Sep 22, 2023
@roiLeo roiLeo added this pull request to the merge queue Sep 22, 2023
Merged via the queue into kodadot:main with commit 2a137d9 Sep 22, 2023
9 of 12 checks passed
@roiLeo roiLeo deleted the chore/upgade/sub-api branch September 22, 2023 13:13
@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

This was referenced Sep 24, 2023
Merged
Merged
Merged
Merged
Merged
@yangwao yangwao mentioned this pull request Sep 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@daiagi daiagi daiagi approved these changes

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update sub-api package
3 participants
@roiLeo @daiagi @vikiival