Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

~ Nuxt3 ~ #7295

Merged
merged 4 commits into from
Sep 19, 2023
Merged

~ Nuxt3 ~ #7295

merged 4 commits into from
Sep 19, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Sep 19, 2023

@roiLeo roiLeo requested a review from a team as a code owner September 19, 2023 07:16
@roiLeo roiLeo requested review from stephenjason89 and Jarsen136 and removed request for a team September 19, 2023 07:16
@netlify
Copy link

netlify bot commented Sep 19, 2023

Deploy Preview for nuxt-kodadot ready!

Name Link
🔨 Latest commit 3fb6e76
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-kodadot/deploys/65094ae1fb1b9f0007e3ac9c
😎 Deploy Preview https://deploy-preview-7295--nuxt-kodadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 19, 2023

AI-Generated Summary: This pull request includes critical changes to multiple files.

The libs/ui/package.json file updates the version of the eslint dependency. Similarly, updates have been made in the package.json file's dependencies; major ones include polkadot/apps-config, transak/transak-sdk, babel/core, playwright/test, vitest/coverage-istanbul, eslint, vitest, and the addition of vite-pwa/nuxttodevDependencies`.

Various .vue files like TransferConfirmModal.vue, GalleryItemPreviewer.vue, ConfirmPurchaseModal.vue, MintingModal.vue, and ListingCartModal.vue switch from two-way data binding (v-model) to one-way data flow (:value), affecting different properties such as isModalActive and isFullscreen.

The nuxt.config.js file has a noteworthy refactoring involving the pwa config. The import statement was altered, modules were replaced, and the pwa property was greatly simplified to be replaced with the imported pwa object.

Finally, a new constant for the progressive web application (PWA), defining configurations like registerType, scope, base, manifest, and workbox, has been added to the utils/config/pwa.ts file. The changes accompanied careful detailing of manifest and workbox, optimizing the web application's functioning.

The modifications need to ensure the adjustment of pwa configurations in ./utils/config/pwa according to these changes.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Sep 19, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 19, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @playwright/test@1.37.1

@roiLeo roiLeo merged commit 5ed65d9 into kodadot:nuxt Sep 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants