Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 nuxt.config & assets store #7047

Merged
merged 42 commits into from
Aug 30, 2023
Merged

🔧 nuxt.config & assets store #7047

merged 42 commits into from
Aug 30, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Aug 30, 2023

daiagi and others added 30 commits August 25, 2023 11:36
Co-authored-by: Stephen Jason Wang <stephenjasonwang@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@roiLeo roiLeo requested a review from a team as a code owner August 30, 2023 12:42
@roiLeo roiLeo requested review from preschian and stephenjason89 and removed request for a team August 30, 2023 12:42
@netlify
Copy link

netlify bot commented Aug 30, 2023

Deploy Preview for nuxt-kodadot ready!

Name Link
🔨 Latest commit 804f438
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-kodadot/deploys/64ef393905b4a50007c27449
😎 Deploy Preview https://deploy-preview-7047--nuxt-kodadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@roiLeo roiLeo merged commit c0c6d32 into kodadot:nuxt Aug 30, 2023
5 of 7 checks passed
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 30, 2023

AI-Generated Summary: This pull request includes changes across multiple Vue.js component files, utility files, localization files and others, revolving around improving accessibility, internationalization, code readability, maintainability and also carrying out major refactors in certain parts to modernize the approach to Vue.js.

HTML tags have been changed across multiple components like ClaimForm.vue, Navbar.vue, Error.vue, Drops.vue, cookie-notice.vue, CarouselAgnostic.vue and IdentityForm.vue to better reflect the semantics of each section and improve accessibility.

Several changes were introduced to localization: hardcoded texts are replaced with localized ones in Navbar.vue, locales/en.json file received several new translations to support English language, and a new modal component TransactionLoader.vue was introduced that supports internationalization.

Significant updates to how the Vue.js codebase is structured are found, such as moving from the Options API to the Composition API in NeoSteps.vue, using enumerative constant over a string literal in Transfer.vue, and adoption of generic types in utils/config/types.ts.

utils/config/types.ts file generalizes the use of PartialConfig to enable more flexibility. useBlockTime.ts file creates URL-specific block time values. Transitions indicate a movement towards a more reusable, scalable and modern codebase in terms of Vue.js best practices.

In terms of styling, modifications are made in CollectionGridWithBreadcrumbs.vue, NeoSteps.scss, and the blog post component with updates around padding, font sizes and more.

Other notable changes include the addition of a mobile breakpoint prop for a modal component, transaction loading behavior updates in Transfer.vue, icon updates in TheFooter.vue, restructuring meta configuration within nuxt.config.js, removal of a redundant line in a blog markdown file, and more.

The scope of changes in this pull request is vast and includes a diverse set of files and components. It paves the way for enhanced user experience, improved code readability and maintainability, and a more modern development strategy.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Aug 30, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 30, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants