Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: nuxt3 vuesocialshare update #7233

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

thnaylor
Copy link
Contributor

@thnaylor thnaylor commented Sep 10, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Comments

  • VueSocialSharing does not support/bugs when used through the nuxt.config.js modules settings but works fine when registering as a plugin.

image

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at a18fb98

This pull request updates the vue-social-sharing dependency to a newer version that supports Vue 3 and Nuxt 3, and adjusts the plugin registration accordingly. It also adds napi-wasm as a dependency for WebAssembly support. It modifies the pnpm-lock.yaml and nuxt.config.js files accordingly.

🤖 Generated by Copilot at a18fb98

To share NFTs with more flair
The plugin vueSocialSharing needed repair
So they updated the version
And changed the plugin insertion
With defineNuxtPlugin to make it more fair

@netlify
Copy link

netlify bot commented Sep 10, 2023

Deploy Preview for nuxt-kodadot ready!

Name Link
🔨 Latest commit a18fb98
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-kodadot/deploys/64fe230a2a70410008410c2d
😎 Deploy Preview https://deploy-preview-7233--nuxt-kodadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 10, 2023

AI-Generated Summary: This pull request includes a few changes aimed at refactoring and upgrading one of the Vue project's dependencies, specifically the vue-social-sharing plugin. The first main action in this patch is the version upgrade of the vue-social-sharing dependency from "^3.0.9" to "4.0.0-alpha4" in the package.json file. In addition, it is being added as a Nuxt plugin in the vueSocialSharing.ts plugin file. The import statement is uncommented, and the VueJS app is now set to use VueSocialSharing. Another noticeable change in this commit is the removal of vueSocialSharing from the nuxt.config.js file. There are also several adjustments in the pnpm-lock.yaml file, indicating that the lockfile version has changed from '6.1' to '6.0' and the vue-social-sharing version has been updated here as well.

@reviewpad reviewpad bot added the small Pull request is small label Sep 10, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 10, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@thnaylor thnaylor changed the title refactor: update vuesocialshare dependency and add as a nuxt plugin refactor: nuxt3 vuesocialshare update Sep 10, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thnaylor thnaylor marked this pull request as ready for review September 10, 2023 20:16
@thnaylor thnaylor requested a review from a team as a code owner September 10, 2023 20:16
@thnaylor thnaylor requested review from preschian and daiagi and removed request for a team September 10, 2023 20:16
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ code lgtm & wfm

@roiLeo roiLeo merged commit 2f36718 into kodadot:nuxt Sep 11, 2023
11 checks passed
@roiLeo roiLeo mentioned this pull request Sep 6, 2023
20 tasks
@yangwao
Copy link
Member

yangwao commented Sep 11, 2023

pay 30 usd

@yangwao
Copy link
Member

yangwao commented Sep 11, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 3.99 USD/DOT ~ 7.519 $DOT
🧗 123PCJXhjb15i6JwVVRGd7KvN2sSNZrtPjr5doJq9oWctoTt
🔗 0x5b84d84cbba276a3bda382e84c006959c40e2104430c681a49e616503f3c4512

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants