Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 NeoModal QRCode #7265

Merged
merged 2 commits into from
Sep 13, 2023
Merged

🔧 NeoModal QRCode #7265

merged 2 commits into from
Sep 13, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Sep 13, 2023 •
edited
Loading

@roiLeo roiLeo requested a review from a team as a code owner September 13, 2023 14:48
@roiLeo roiLeo requested review from stephenjason89 and prury and removed request for a team September 13, 2023 14:48
@netlify
Copy link

netlify bot commented Sep 13, 2023 •
edited
Loading

✅ Deploy Preview for nuxt-kodadot ready!

Name Link
🔨 Latest commit 98cdb1b
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-kodadot/deploys/6501cbe3acff650008b1d8d5
😎 Deploy Preview https://deploy-preview-7265--nuxt-kodadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 13, 2023

AI-Generated Summary: This pull request incorporates several updates across 13 files mainly concentrating on the Vue Component, NeoModal. The changes include replacing v-model bindings with a :value props. The QR code component has also been updated, outlining the sourced library switch from @chenfengyuan/vue-qrcode to qrcode.vue. A couple of necessary qrcode.vue package details were also added to the package.json and pnpm-lock.yaml. Also, some parts of the QRCode component previously commented have been uncommented and adjusted to accommodate the new library changes.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Sep 13, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 13, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@roiLeo roiLeo merged commit d4e951e into kodadot:nuxt Sep 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenjason89 stephenjason89 Awaiting requested review from stephenjason89 stephenjason89 was automatically assigned from kodadot/code-review-guild

@prury prury Awaiting requested review from prury prury was automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@roiLeo