Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: nuxt3 vueclipboard plugin #7229

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

thnaylor
Copy link
Contributor

@thnaylor thnaylor commented Sep 9, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Comments

  • Created a directive from 'useClipboard' to function the same 'vue-clipboard2' and also keeping original functionality of 'useClipboard' by allowing destructure of object from the plugin.
  • Alternatively replace old directive in all components with 'useClipboard'. 🤷‍♂️

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at a41d5e7

Moved styles folder to assets folder and updated SCSS import paths. Modified ESLint configuration to work better with TypeScript.

🤖 Generated by Copilot at a41d5e7

We're moving styles to assets, me hearties, yo ho ho
We're following the Nuxt way, and make the project glow
We're fixing ESLint conflicts, with TypeScript on board
We're warning no-empty-function, and keep the code in order

@netlify
Copy link

netlify bot commented Sep 9, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit a41d5e7
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64fcd0a8086657000814587d
😎 Deploy Preview https://deploy-preview-7229--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 29935 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Sep 9, 2023

Code Climate has analyzed commit a41d5e7 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

View more on Code Climate.

@reviewpad reviewpad bot added the large Pull request is large label Sep 9, 2023
@thnaylor thnaylor changed the base branch from main to nuxt September 9, 2023 20:09
@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 9, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@reviewpad reviewpad bot added small Pull request is small and removed large Pull request is large labels Sep 9, 2023
@socket-security
Copy link

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
rollup 2.0.0 None +0 2.65 MB lukastaegert
vite 3.2.7...4.2.0 environment +4/-3 3.78 MB vitebot
histoire 0.17.0...0.16.2 None +4/-5 3.94 MB akryum

🚮 Removed packages: @nuxt/bridge-edge@3.0.0-27889410.9247608, nuxt-edge@2.17.2-28202417.20abbc1

@thnaylor thnaylor marked this pull request as ready for review September 9, 2023 20:37
@thnaylor thnaylor requested a review from a team as a code owner September 9, 2023 20:37
@thnaylor thnaylor requested review from preschian and floyd-li and removed request for a team September 9, 2023 20:37
@roiLeo roiLeo self-requested a review September 9, 2023 21:23
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ code lgtm & wfm

@roiLeo roiLeo mentioned this pull request Sep 6, 2023
20 tasks
@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for nuxt-kodadot ready!

Name Link
🔨 Latest commit f7475b1
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-kodadot/deploys/64fececaab1238000850d920
😎 Deploy Preview https://deploy-preview-7229--nuxt-kodadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@roiLeo roiLeo merged commit 692e72b into kodadot:nuxt Sep 11, 2023
6 of 8 checks passed
@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yangwao
Copy link
Member

yangwao commented Sep 11, 2023

pay 30 usd

@yangwao
Copy link
Member

yangwao commented Sep 11, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 3.99 USD/DOT ~ 7.519 $DOT
🧗 123PCJXhjb15i6JwVVRGd7KvN2sSNZrtPjr5doJq9oWctoTt
🔗 0x9407cda656d7ef86fcd6ed0141a502bcd74927b9020a5deb727e83232e9f0f98

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants