Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 drops watcheffect #7558

Merged
merged 2 commits into from
Oct 9, 2023
Merged

🔧 drops watcheffect #7558

merged 2 commits into from
Oct 9, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Oct 9, 2023 •
edited
Loading

ref #7375

clicking on Drops link and then going to another page and clicking the drops link again shows no active drops

Step to reproduce:

  • click on drops in navbar
  • click on any link
  • click on drops in navbar again
  • content empty

@roiLeo roiLeo requested a review from a team as a code owner October 9, 2023 12:03
@roiLeo roiLeo requested review from preschian and floyd-li and removed request for a team October 9, 2023 12:03
@netlify
Copy link

netlify bot commented Oct 9, 2023 •
edited
Loading

✅ Deploy Preview for nuxt-kodadot ready!

Name Link
🔨 Latest commit d5bf6c1
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-kodadot/deploys/6523ecde80705a0008dc9627
😎 Deploy Preview https://deploy-preview-7558--nuxt-kodadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 9, 2023

AI-Generated Summary: This pull request includes a minor modification to the useDrops component. In particular, the watch function has been replaced with the watchEffect function. There is no change in the arguments passed to these functions or the encapsulated logic. This aims to enhance the efficient observation of reactive dependencies.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 9, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 9, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@roiLeo roiLeo requested a review from prury October 9, 2023 12:04
@roiLeo roiLeo mentioned this pull request Oct 9, 2023
Closed
60 tasks
@roiLeo roiLeo merged commit 10de333 into kodadot:nuxt Oct 9, 2023
1 check passed
@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@prury prury mentioned this pull request Oct 10, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@floyd-li floyd-li Awaiting requested review from floyd-li floyd-li was automatically assigned from kodadot/code-review-guild

@prury prury Awaiting requested review from prury

Assignees
No one assigned
Labels
small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roiLeo @preschian