Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Enviroment var to expand test cases" #7954

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

prury
Copy link
Member

@prury prury commented Nov 6, 2023

Reverts #7849

@prury prury requested a review from a team as a code owner November 6, 2023 14:25
@prury prury requested review from preschian and floyd-li and removed request for a team November 6, 2023 14:25
Copy link

netlify bot commented Nov 6, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 8ef200b
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6548f74bc4c1480008806756
😎 Deploy Preview https://deploy-preview-7954--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

reviewpad bot commented Nov 6, 2023

AI-Generated Summary: This pull request reverts changes related to environment variables used to expand test cases. The patch removes usage of the "MNEMONIC_E2E" environment variable from the .env.example and nuxt.config.ts files, as well as removing it from a setup action in the Playwright GitHub workflow. There are also changes in how the mnemonic is generated in the e2e-login.vue page, now using "mnemonicGenerate(12)" instead of fetching it from the environment variable. Moreover, the account.spec.ts test file has been deleted and a minor modification has been made in createcollection.spec.ts test case.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Nov 6, 2023
Copy link
Contributor

reviewpad bot commented Nov 6, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

Copy link

codeclimate bot commented Nov 6, 2023

Code Climate has analyzed commit 8ef200b and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@prury prury requested a review from roiLeo November 6, 2023 14:26
@yangwao
Copy link
Member

yangwao commented Nov 6, 2023

so which part doesn't work?

@prury
Copy link
Member Author

prury commented Nov 6, 2023

so which part doesn't work?

it fails to access the github secret containing the environment variable, because it will always run from a forked repo(just a guess)

@yangwao yangwao merged commit e7defb7 into kodadot:main Nov 6, 2023
13 of 14 checks passed
@prury prury deleted the revert-7849-pw-fix-2 branch November 9, 2023 12:58
This was referenced Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants