Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Enviroment var to expand test cases" #7954

Merged
merged 1 commit into from
Nov 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,3 @@ SUBSQUID_ENDPOINT=""
RAMP_API_KEY=""
TRANSAK_API_KEY=""
TRANSAK_ENV="" #STAGING|PRODUCTION
MNEMONIC_E2E=""
5 changes: 0 additions & 5 deletions .github/workflows/playwright.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,6 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version: 18

- name: Set Enviroment Variable
run: |
touch .env
echo MNEMONIC_E2E=${{ secrets.MNEMONIC_E2E }} >> .env

- name: Install dependencies
uses: ./.github/actions/pnpm-install
Expand Down
1 change: 0 additions & 1 deletion nuxt.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,6 @@ export default defineNuxtConfig({
rampApiKey: process.env.RAMP_API_KEY,
transakApiKey: process.env.TRANSAK_API_KEY || '',
transakEnvironment: process.env.TRANSAK_ENV || 'PRODUCTION',
e2eMnemonic: process.env.MNEMONIC_E2E,
},
},
// In case of using ssr
Expand Down
4 changes: 2 additions & 2 deletions pages/e2e-login.vue
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
</template>

<script lang="ts">
import { mnemonicGenerate } from '@polkadot/util-crypto'
import keyring from '@polkadot/ui-keyring'
import { ss58Of } from '@/utils/config/chain.config'
import { useIdentityStore } from '@/stores/identity'
Expand All @@ -17,8 +18,7 @@ export default {
const mockAddress = ref(false)

onMounted(() => {
const mnemonicEnv = useRuntimeConfig().public.e2eMnemonic
const mnemonic = String(mnemonicEnv)
const mnemonic = mnemonicGenerate(12)
const { pair } = keyring.addUri(mnemonic, '', {
name: 'mnemonic acc',
})
Expand Down
11 changes: 0 additions & 11 deletions tests/e2e/account.spec.ts

This file was deleted.

2 changes: 1 addition & 1 deletion tests/e2e/createcollection.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ test('Fill fields to check if they work', async ({ page }) => {
await expect(
page
.getByTestId('collection-create')
.filter({ has: page.getByText('Create New Collection') }),
.filter({ has: page.getByText('Not Enough Funds') }),
).toHaveCount(1)
})

Expand Down
Loading