[Fix rubocop#126] Mark Minitest/AssertWithExpectedArgument as unsafe

Fixes rubocop#126. This PR marks `Minitest/AssertWithExpectedArgument` as unsafe. This cop is marked as unsafe, because it is not possible to determine whether the second argument of `assert` is a message or not.
koic · Mar 22, 2021 · 9167de4 · 9167de4
1 parent 0d47b7e
commit 9167de4
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## master (unreleased)
 
+### Changes
+
+* [#126](https://github.com/rubocop/rubocop-minitest/issues/126): Mark `Minitest/AssertWithExpectedArgument` as unsafe. ([@koic][])
+
 ## 0.11.0 (2021-03-22)
 
 ### New features

diff --git a/config/default.yml b/config/default.yml
@@ -97,6 +97,7 @@ Minitest/AssertTruthy:
 Minitest/AssertWithExpectedArgument:
   Description: 'This cop tries to detect when a user accidentally used `assert` when they meant to use `assert_equal`.'
   Enabled: pending
+  Safe: false
   VersionAdded: '0.11'
 
 Minitest/GlobalExpectations:

diff --git a/lib/rubocop/cop/minitest/assert_with_expected_argument.rb b/lib/rubocop/cop/minitest/assert_with_expected_argument.rb
@@ -6,6 +6,9 @@ module Minitest
       # This cop tries to detect when a user accidentally used
       # `assert` when they meant to use `assert_equal`.
       #
+      # It is marked as unsafe because it is not possible to determine
+      # whether the second argument of `assert` is a message or not.
+      #
       # @example
       #   # bad
       #   assert(3, my_list.length)