Minitest/AssertWithExpectedArgument flags a common assertion in model tests.

[ccasabona]

The new Minitest/AssertWithExpectedArgument cop flags a valid assertion used in Rails model tests.

With a User class that has a required name attribute, a test for this may be written as:

    test 'name exists' do
      @user.name = ''
      assert @user.invalid?, @user.errors[:name]
      assert_equal [I18n.t('errors.messages.blank')], @user.errors[:name]
      @user.name = 'charlie'
      assert @user.valid?, @user.errors.full_messages
    end

The last assertion, assert @user.valid?, @user.errors.full_messages, is (or used to be) an acceptable way of returning an unexpected error message for an assert something.valid? statement that you expect to be true. Should the @user instance not be valid, any errors are displayed.

Obviously, once the unexpected condition is corrected, the @user.error.full_messages part of the statement is no longer needed. Our model tests, however, have about 1300 lines that use this structure.

[koic]

RuboCop Minitest 0.11.1 has been released with unsafe mark to the cop. In the future, if there are many similar issues, I think this cop can consider disabling it by default. Thank you for your feedback.

[ccasabona]

Thank you for looking into this.

…

On Mar 30, 2021, at 12:50 PM, Koichi ITO ***@***.***> wrote: RuboCop Minitest 0.11.1 has been released with unsafe mark to the cop. In the future, if there are many similar issues, I think this cop can consider disabling it by default. Thank you for your feedback. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#126 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABQTUIQO2KOPSRNTWQLTST3TGH6OHANCNFSM4ZR4UFJQ>.