Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Koinos cli expects arguments even if the function doesn't have arguments #192

Closed
1 task done
joticajulian opened this issue Jul 26, 2023 · 0 comments · Fixed by #193
Closed
1 task done
Labels
bug Something isn't working

Comments

@joticajulian
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

Fogata pools have have functions like this in the ABI:

      "reburn_and_snapshot": {
      "argument": "",
      "return": "common.boole",
      "description": "Function to be called periodically by anyone to reburn the KOINs that was not withdrawn in the previous snapshot and take a new snapshot. The vapor that was not withdrawn is distributed to all users.",
      "entry_point": 2129709095,
      "entry-point": "0x7ef0c827",
      "read_only": false,
      "read-only": false
    },

as you see, the argument is empty. In koilib this is interpreted like a function without arguments. Koinos CLI has problems resolving this ABI because it expects an argument even if the function don't use it.

Expected behavior

ignore the "argument" type or "return" type if they are not provided.

Steps to reproduce

No response

Environment

- OS:

Anything else?

No response

@joticajulian joticajulian added the bug Something isn't working label Jul 26, 2023
sgerbino added a commit that referenced this issue Dec 4, 2023
#192: Insert dummy message if args or return are empty in ABI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant