Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#192: Insert dummy message if args or return are empty in ABI #193

Merged
merged 1 commit into from
Dec 4, 2023
Merged

#192: Insert dummy message if args or return are empty in ABI #193

merged 1 commit into from
Dec 4, 2023

Conversation

mvandeberg
Copy link
Member

Resolves #192

Brief description

When no arguments are provided in the ABI, replace them with the default nop_arguments. The same goes for return types.

Checklist

  • I have built this pull request locally
  • I have ran the unit tests locally
  • I have manually tested this pull request
  • I have reviewed my pull request
  • I have added any relevant tests

Demonstration

@sgerbino sgerbino merged commit b39d1d1 into master Dec 4, 2023
3 checks passed
@sgerbino sgerbino deleted the 192-void-args branch December 4, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgerbino sgerbino sgerbino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Koinos cli expects arguments even if the function doesn't have arguments
2 participants
@mvandeberg @sgerbino