Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace KOKKOS_HAVE_* FLAGS with KOKKOS_ENABLE_* #219

Closed
mndevec opened this issue Apr 24, 2018 · 3 comments
Closed

Replace KOKKOS_HAVE_* FLAGS with KOKKOS_ENABLE_* #219

mndevec opened this issue Apr 24, 2018 · 3 comments
Assignees
@kyungjoo-kim @crtrott @srajama1 @ndellingwood
Labels
InDevelop

Comments

@mndevec
Copy link
Contributor

mndevec commented Apr 24, 2018

KOKKOS_HAVE_* flags are deprecated in kokkos. Every where it appears as MACRO should be replaced with KOKKOS_ENABLE_*
@ndellingwood
Copy link
Contributor

Addressed (partially) by #218, thanks @mndevec !

@kyungjoo-kim
Copy link
Contributor

Batch functions (src, unit_test, perf_test) in kokkos kernels does not use the macro KOKKOS_HAVE.

ndellingwood added a commit that referenced this issue May 3, 2018
@ndellingwood
Enable with deprecated code: round 1 - KOKKOS_HAVE to KOKKOS_ENABLE
390b8db 
Part of issues #223 and #219
@ndellingwood ndellingwood mentioned this issue May 3, 2018
Merged
@ndellingwood
Copy link
Contributor

Updated in PR #227

@ndellingwood ndellingwood mentioned this issue May 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyungjoo-kim kyungjoo-kim

@crtrott crtrott

@srajama1 srajama1

@ndellingwood ndellingwood

Labels
InDevelop
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kyungjoo-kim @crtrott @srajama1 @ndellingwood @mndevec