Kokkoskernels sparse failures

[mndevec]

KOKKOS_HAVE_PTHREADS flag seems to be removed from kokkos. All KOKKOS_HAVE_ flags are changed to KOKKOS_ENABLE in this commit.

On Shepard the test that was previously failing:

./test_all_sandia intel/17.4.196 --build-list=Pthread 
Going to test compilers:  intel/17.4.196
Testing compiler intel/17.4.196
  Starting job intel-17.4.196-Pthread-release
  PASSED intel-17.4.196-Pthread-release
#######################################################
PASSED TESTS
#######################################################
intel-17.4.196-Pthread-release build_time=336 run_time=349
#######################################################
FAILED TESTS
#######################################################

I am testing on white and will post the results here.

[crtrott]

Uhoh this shouldnt have happened if you dont turn disabled code off. We need to track this down and fix it on the Kokkos side. That said it is correct to remove the deprecated kokkos_have stuff from kokkos kernels

[mndevec]

white: with cuda

-bash-4.2$ bsub -Is -q rhel7F ./test_all_sandia cuda/8.0.44
***Forced exclusive execution
Job <32313> is submitted to queue <rhel7F>.
<<Waiting for dispatch ...>>
<<Starting on white23>>
Going to test compilers:  cuda/8.0.44
Testing compiler cuda/8.0.44
  Starting job cuda-8.0.44-Cuda_OpenMP-release
  PASSED cuda-8.0.44-Cuda_OpenMP-release
  Starting job cuda-8.0.44-Cuda_Serial-release
  PASSED cuda-8.0.44-Cuda_Serial-release
#######################################################
PASSED TESTS
#######################################################
cuda-8.0.44-Cuda_OpenMP-release build_time=808 run_time=500
cuda-8.0.44-Cuda_Serial-release build_time=760 run_time=855
#######################################################
FAILED TESTS
#######################################################

[mndevec]

@crtrott : it may be something I am doing wrong, but it looks like KOKKOS_HAVE_PTHREAD is not set anymore.

#include "Kokkos_Core.hpp"
#include "stdio.h"

int main() {

#ifdef KOKKOS_HAVE_PTHREAD
  printf("KOKKOS_HAVE_PTHREAD\n")
#endif

#ifdef KOKKOS_ENABLE_THREADS
  printf("KOKKOS_ENABLE_THREADS\n");
#endif

};

this prints only "KOKKOS_ENABLE_THREADS"

[mndevec]

Content of KokkosCore_config.h

/* ---------------------------------------------
Makefile constructed configuration:
Mon Apr 23 17:27:13 MDT 2018
----------------------------------------------*/
#if !defined(KOKKOS_MACROS_HPP) || defined(KOKKOS_CORE_CONFIG_H)
#error "Do not include KokkosCore_config.h directly; include Kokkos_Macros.hpp instead."
#else
#define KOKKOS_CORE_CONFIG_H
#endif
/* Execution Spaces */
#define KOKKOS_ENABLE_THREADS
#ifndef __CUDA_ARCH__
#define KOKKOS_USE_ISA_X86_64
#endif
/* General Settings */
#define KOKKOS_ENABLE_CXX11
#define KOKKOS_ENABLE_PROFILING
#define KOKKOS_ENABLE_DEPRECATED_CODE
/* Optimization Settings */
/* Cuda Settings */
#define KOKKOS_ARCH_AVX2

[ndellingwood]

@mndevec Is this debugging output or intentional?

[mndevec]

ops :)

[mndevec]

I pushed to delete this.