Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix out-of-bounds when bins are empty #1503

Merged
merged 1 commit into from
Mar 29, 2018
Merged

Fix out-of-bounds when bins are empty #1503

merged 1 commit into from
Mar 29, 2018

Conversation

ibaned
Copy link
Contributor

@ibaned ibaned commented Mar 29, 2018 •
edited
Loading

This should fix many of the failures pointed out in trilinos/Trilinos#2471 . There would be out-of-bounds accesses if bins are empty in sorting.

@ibaned ibaned added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Mar 29, 2018
@ibaned ibaned requested review from dsunder and crtrott March 29, 2018 15:50
@ibaned ibaned mentioned this pull request Mar 29, 2018
Closed
@ibaned
Copy link
Contributor Author

ibaned commented Mar 29, 2018

The corresponding issue for book-keeping is #1504. spot check started.

ibaned added a commit to trilinos/Trilinos that referenced this pull request Mar 29, 2018
@ibaned
Kokkos: fix Sort bug with empty bins
2305cfe 
See #2471 and kokkos/kokkos#1503
Out-of-bounds access when sorting
an empty bin.
@ibaned ibaned mentioned this pull request Mar 29, 2018
Merged
@ibaned
Copy link
Contributor Author

ibaned commented Mar 29, 2018

Passes spot check:

Running on machine: sems
Repository Status:  ca0704caa2a9c9720e7cc8a4d54fd3e25e3bd76c Fix out-of-bounds when bins are empty


Going to test compilers:  gcc/5.3.0 gcc/6.1.0 intel/17.0.1 clang/3.9.0 cuda/8.0.44
Testing compiler gcc/5.3.0
Testing compiler gcc/6.1.0
  Starting job gcc-6.1.0-Serial-release
  Starting job gcc-5.3.0-OpenMP-release
  Starting job gcc-5.3.0-OpenMP-hwloc-release
  PASSED gcc-6.1.0-Serial-release
Testing compiler intel/17.0.1
  Starting job gcc-6.1.0-Serial-hwloc-release
  PASSED gcc-5.3.0-OpenMP-release
  PASSED gcc-5.3.0-OpenMP-hwloc-release
Testing compiler clang/3.9.0
  Starting job intel-17.0.1-OpenMP-release
  Starting job intel-17.0.1-OpenMP-hwloc-release
  PASSED gcc-6.1.0-Serial-hwloc-release
  Starting job clang-3.9.0-Pthread_Serial-release
  PASSED clang-3.9.0-Pthread_Serial-release
Testing compiler cuda/8.0.44
  Starting job clang-3.9.0-Pthread_Serial-hwloc-release
  PASSED clang-3.9.0-Pthread_Serial-hwloc-release
  PASSED intel-17.0.1-OpenMP-release
  PASSED intel-17.0.1-OpenMP-hwloc-release
  Starting job cuda-8.0.44-Cuda_OpenMP-release
  PASSED cuda-8.0.44-Cuda_OpenMP-release
#######################################################
PASSED TESTS
#######################################################
clang-3.9.0-Pthread_Serial-hwloc-release build_time=200 run_time=92
clang-3.9.0-Pthread_Serial-release build_time=197 run_time=206
cuda-8.0.44-Cuda_OpenMP-release build_time=506 run_time=569
gcc-5.3.0-OpenMP-hwloc-release build_time=267 run_time=249
gcc-5.3.0-OpenMP-release build_time=266 run_time=249
gcc-6.1.0-Serial-hwloc-release build_time=175 run_time=166
gcc-6.1.0-Serial-release build_time=210 run_time=154
intel-17.0.1-OpenMP-hwloc-release build_time=881 run_time=492
intel-17.0.1-OpenMP-release build_time=939 run_time=424

@crtrott crtrott merged commit ff58fcf into develop Mar 29, 2018
@crtrott crtrott deleted the sort-empty-bins branch March 29, 2018 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crtrott crtrott crtrott approved these changes

@dsunder dsunder Awaiting requested review from dsunder

Assignees
No one assigned
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibaned @crtrott