Kokkos: fix Sort bug with empty bins #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #2471 and kokkos/kokkos#1503 Out-of-bounds access when sorting an empty bin.
ibaned
added
type: bug
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Using Repos:
Pull Request Author: ibaned |
bartlettroscoe
approved these changes
Mar 29, 2018
There was a problem hiding this comment.
Looks reasonable to me. If there is 1 or 0 elements, don't bother sorting.
The thing that would make this better is if there was a unit test in Kokkos itself for this test case. I don't want to hold up the merge of this PR (because we have failing tests submitting CDash error emails this will clean up) but could someone add a unit test in Kokkos itself for 0 and 1 sizes?
mndevec
approved these changes
Mar 29, 2018
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ bartlettroscoe mndevec ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/kokkos
Description
This fixes a bug in Kokkos where an access would be made out of bounds when sorting with empty bins.
Motivation and Context
This bug was causing test failures in the new ATDM builds with
KOKKOS_ENABLE_DEBUG=ON, pushing the fix directly to Trilinos will help fix some of those failures.Related Issues
How Has This Been Tested?
A custom build with
KOKKOS_ENABLE_DEBUGpasses the KokkosKernels test that used to fail.