fix(STONEINTG-897): don't require chains for failed build PLRs #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* It's not guaranteed that a failed build pipelineRun will be processed by Tekton chains * The integration service still needs to process those pipelineRuns in order to remove their finalizers Signed-off-by: dirgim <kpavic@redhat.com> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
dirgim
requested review from
hongweiliu17,
jsztuka,
Josh-Everett,
kasemAlem,
sonam1412,
dheerajodha,
14rcole,
jencull and
chipspeak
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #873 +/- ##
=======================================
Coverage ? 69.12%
=======================================
Files ? 43
Lines ? 4447
Branches ? 0
=======================================
Hits ? 3074
Misses ? 1054
Partials ? 319 ☔ View full report in Codecov by Sentry. |
Josh-Everett
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dirgim kpavic@redhat.com
Maintainers will complete the following section