2023 10 27 spark for25 #377
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add accessibility check for candidate metadata, not just visits.
This was made to remove overrides on COPN and CBIGR - removes notices - removes deprecation warning - add filter options to filter with limited set of options
Checkbox elements can not be defined as required like the rest of the elements. This add support for required. A required checkbox must be checked for the form to be submitted. (ie. for questions like "Have you read the terms of service?")
In the feedback panel for an instrument, the only option in 'Field Name' was 'Across all fields'. This changes how the field names for an instrument are fetched so that all of them appear as an option too.
- Fix date imported into DQT to be a real date rather than a unix timestamp. - Fix incorrect order of parameters to `join` in import script
Do not escape data being inserted in the issue tracker, it gets escaped on rendering.
Currently the numeric element type is only being added to the instrument data dictionary if it's on the top page. This fixes it so that the elements are always added to the dictionary regardless of the page.
Fix display of bvl_feedback on mobile devices. - Switched Add Comment button from Pencil to a Comment (Original was confusing) - Set threads to be shown automatically for open threads as having them hidden made the UI confusing. - Added an Edit and Delete button for comments of which the author is the user viewing them - Flipped the order of comments around so that the newer comments show up below. Makes more sense when reading the comments - Made New Comment TextArea section show up below the thread, as that is where the new comment will appear - Changed panel width to work on mobile devices
This change enables the use of project modules for requests that use AjaxHelper. The order in which the directories are defined, when the LorisInstance is instantiated, determines the order of locations where modules are searched for and registered.
Properly handle parsing/auto-populating of visit label when there is a suffix after the visit label in the file name. Fixes aces#8803
Some instruments use hidden fields to pass data to the frontend. This skips over the fields in the dictionary building to prevent a 500 error.
PR#8759 converted the escape module to use unsafeInsert/update to save data and prevent double escaping issues. The usages of the textarea were audited to make sure they were properly escaped, however the value is also displayed in the configuration module itself. Until the module is updated from smarty to react (PR#8471), they need to be escaped in the config module itself. This adds escaping to the config module smarty template.
This fixes 2 problems with the SQL in the media FileUpload?action=getData endpoint 1. There is an obvious SQL injection attack where user input from the request is directly concatenated into a string that's passed to the database. 2. There was an unnecessary sub-select that could have been a join This whole section of the code is a mess that should to be re-written, but this PR just tackles the urgent string concatenation.
Push 24.1.5 bugfixes into the 25.0.x release branch.
Push v24.1.5 bug fixes into v25.0.x release branch
Modified Form.js to no longer use the "selected" attribute in option tags, and rather the "value" attribute of select tags. Resolves aces#8702
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Testing instructions (if applicable)
Link(s) to related issue(s)